1
0
mirror of https://git.FreeBSD.org/ports.git synced 2025-01-27 10:03:20 +00:00
freebsd-ports/comms/unixcw/Makefile
Tijl Coosemans 1bf487d3e7 Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] 5c2cbfccf9
[2] 2ed5054e3a
[3] 009f5ebb4b

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)
2019-01-16 11:13:44 +00:00

58 lines
1.4 KiB
Makefile

# $FreeBSD$
# NOTE: comms/xcwcp is a sub-port of this. When making changes, ensure
# it still works as well.
PORTNAME?= unixcw
PORTVERSION= 3.5.1
PORTREVISION?= 0
CATEGORIES= comms hamradio
MASTER_SITES= SF/unixcw/unixcw-${PORTVERSION}
DISTNAME= unixcw_${PORTVERSION}.orig
MAINTAINER= hamradio@FreeBSD.org
COMMENT?= Libs for cw on unix
LICENSE= GPLv2
LICENSE_FILE= ${WRKSRC}/COPYING
GNU_CONFIGURE= yes
.ifndef CONFIGURE_ARGS
CONFIGURE_ARGS= --disable-xcwcp
.endif
CONFIGURE_ARGS+= --includedir="${LOCALBASE}/include" \
--libdir="${LOCALBASE}/lib"
CPPFLAGS+= -I${LOCALBASE}/include
LDFLAGS+= -L${LOCALBASE}/lib
#CONFIGURE_ENV+= LDFLAGS=-L${LOCALBASE}/lib CPPFLAGS=-I${LOCALBASE}/include
USES+= gmake libtool ncurses pathfix pkgconfig autoreconf
USE_LDCONFIG= yes
USE_CSTD= gnu99
WRKSRC= ${WRKDIR}/unixcw-${PORTVERSION}
MAJOR_LIB_VER= 6
MINOR_LIB_VER= 6.1
PLIST_SUB= MAJOR_LIB_VER=${MAJOR_LIB_VER}
PLIST_SUB+= MINOR_LIB_VER=${MINOR_LIB_VER}
OPTIONS_DEFINE= NLS
NLS_USES= gettext
NLS_CONFIGURE_ENABLE= nls
.ifndef XCWCP
OPTIONS_DEFINE+= ALSA PULSEAUDIO
OPTIONS_DEFAULT+= ALSA PULSEAUDIO
ALSA_CONFIGURE_ENABLE= alsa
PULSEAUDIO_CONFIGURE_ENABLE= pulseaudio
ALSA_BUILD_DEPENDS= ${LOCALBASE}/include/alsa/asoundlib.h:audio/alsa-lib
PULSEAUDIO_BUILD_DEPENDS= ${LOCALBASE}/include/pulse/simple.h:audio/pulseaudio
.endif
post-install:
.ifndef XCWCP
${STRIP_CMD} ${STAGEDIR}${PREFIX}/lib/libcw.so.${MAJOR_LIB_VER}.${MINOR_LIB_VER}
.endif
.include <bsd.port.mk>