1
0
mirror of https://git.FreeBSD.org/ports.git synced 2024-12-21 04:06:46 +00:00
freebsd-ports/converters
Kubilay Kocak 99f578691b converters/py-rencode: Fails to configure if cython is installed
ports r482774 removed USE_PYTHON=cython, likely due to it (cython) not
being explicitly declared as a dependency in setup.py:*_requires.

However, setup.py conditionally builds with cython if it is installed, but
the 1.0.6 source distribution (sdist) does not contain a .pyx file to build
with.

This leads to a configure/build error when cython is installed:

  ValueError: 'rencode/rencode.pyx' doesn't match any files

Upstream commit 5c928f14567fabc9efb8bbb8ac5e0eef03c61541 [1] via issue
#25 [2] adds the required .pyx file to the sdist, which technically
addresses the "build with cython from the sdist" issue, but does not
fundamentally resolve the higher-level question: why build with cython when
a C source pre-processed by cython has already been produced for, and is
contained in, the source distribution.

A cython build (and the dependency on cython) does not appear to be
necessary, nor intended [3][4], nor recommended [5], even after #25 is
released, for sdist consumers.

The conditional code to build with cython should not be included in
setup.py, at least not as a default case, or without an explicit request
by the user to use cython, as an optional build method, for sdist consumers
(most downstream packagers and setuptools/pip users [6]).

This change removes the conditional check for Cython, leaving the standard
setuptools build_ext (with the packaged .c) file, as the build method.

While I'm here:

 - Canonicalise COMMENT (match seutp.py:description)
 - Add test target with post-patch target to make the tests dir a module
   usable by a setup.py test (via test_suite directive) target.
 - Honour CFLAGS: Remove forced (appended) -O3 arg from setup.py

[1] 5c928f1456
[2] https://github.com/aresch/rencode/pull/25
[3] setup.py: "Error: sdist requires cython module to generate `.c` file."
[4] dev-requirements.txt:Cython
[5] https://cython.readthedocs.io/en/latest/src/userguide/source_files_and_compilation.html#distributing-cython-modules
[6] https://github.com/aresch/rencode/issues/11

PR:		233561
Reported by:	John Hein <z7dr6ut7gs snkmail com>
Approved by:	koobs (python)
2018-11-28 05:51:49 +00:00
..
aish
ascii2binary
asr10
base64
bibtexconv
bsdconv
btoa
chmview
cl-babel
cl-babel-sbcl Bump PORTREVISION on *-sbcl ports after lang/sbcl upgrade. 2018-11-02 19:21:19 +00:00
cmios9
cocot
convmv
dosunix Return tj's ports to the pool after his commit bit got safekept. 2018-11-06 21:13:54 +00:00
drg2sbg
dumpasn1
enca
erlang-base64url Add DOCS options to ports that should have one. 2018-09-10 13:14:50 +00:00
fconv
fix-mime-charset
fondu
fpc-iconvenc
fribidi
gbase
gbsdconv
hs-aeson
hs-aeson-compat
hs-aeson-pretty
hs-json
hs-sandi
htx
i18ntools
ical2html
iconv
iconv-extra
iconv-rfc1345
ish
libb64
libiconv
libticonv
libutf-8
lua51-iconv converters/lua*-iconv: enable -fPIC on arm64 and i386, for lld 2018-09-18 19:53:46 +00:00
lua-iconv converters/lua*-iconv: enable -fPIC on arm64 and i386, for lld 2018-09-18 19:53:46 +00:00
lua-json
mimelib
mmencode
mpack
nomyso
o3read
ocaml-base64
ocaml-jsonm
osm2mp
osm2pgrouting devel/boost-*: update to 1.68.0 2018-08-09 06:58:30 +00:00
osm2pgsql devel/boost-*: update to 1.68.0 2018-08-09 06:58:30 +00:00
p5-Bencode
p5-Boulder Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-bsdconv
p5-Convert-ASCII-Armour - Add LICENSE 2018-10-10 09:08:40 +00:00
p5-Convert-ASN1
p5-Convert-Base32
p5-Convert-Bencode
p5-Convert-Bencode_XS
p5-Convert-BER
p5-Convert-Binary-C
p5-Convert-BinHex
p5-Convert-IBM390
p5-Convert-Moji
p5-Convert-Morse
p5-Convert-NLS_DATE_FORMAT
p5-Convert-PEM
p5-Convert-Recode
p5-Convert-TNEF Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-Convert-UU
p5-Convert-UUlib
p5-Cpanel-JSON-XS Update to 4.07 2018-11-04 18:56:18 +00:00
p5-Cstools
p5-Data-AMF
p5-Encode
p5-Encode-Base32-Crockford
p5-Encode-Base32-GMP
p5-Encode-Base58-GMP
p5-Encode-compat Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-Encode-Detect
p5-Encode-Detect-CJK
p5-Encode-DoubleEncodedUTF8 Reassign all of tobez@'s p5 ports to perl@. 2018-09-10 11:16:59 +00:00
p5-Encode-IMAPUTF7
p5-Encode-JIS2K
p5-Encode-Locale
p5-Encode-Punycode
p5-Encoding-BER
p5-Encoding-FixLatin Reassign all of tobez@'s p5 ports to perl@. 2018-09-10 11:16:59 +00:00
p5-Format-Human-Bytes
p5-JSON
p5-JSON1
p5-JSON-Any Undeprecate and unexpire ports that were not correctly deprecated, all ports 2018-08-12 08:06:23 +00:00
p5-JSON-DWIW
p5-JSON-MaybeXS Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-JSON-PP
p5-JSON-Tiny
p5-JSON-XS Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-JSON-XS-VersionOneAndTwo
p5-LaTeXML Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-MIME-Base32
p5-MIME-Base64
p5-MIME-Base64-URLSafe
p5-Net-IDN-Nameprep
p5-Number-Nary Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-Number-RecordLocator Reassign all of tobez@'s p5 ports to perl@. 2018-09-10 11:16:59 +00:00
p5-PerlIO-via-Unidecode
p5-plutil
p5-Sereal Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-Sereal-Decoder
p5-Sereal-Encoder
p5-Storable-AMF
p5-String-Multibyte
p5-Text-Bidi Add LICENSE_FILE 2018-09-24 11:13:16 +00:00
p5-Text-Iconv
p5-Text-Unidecode Reassign all of tobez@'s p5 ports to perl@. 2018-09-10 11:16:59 +00:00
p5-Unicode-IMAPUtf7 Remove compatibility code for FreeBSD < 11.2 from all ports. 2018-11-02 13:32:34 +00:00
p5-Unicode-Map - Add LICENSE 2018-09-03 09:08:16 +00:00
p5-Unicode-Map8 Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-Unicode-MapUTF8 Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-Unicode-RecursiveDowngrade
p5-Unicode-String
p5-Unicode-Stringprep Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-Unicode-UTF8simple
p5-URI-UTF8-Punycode
p5-WAP-wbxml Fix every instance of RUN_DEPENDS:=${BUILD_DEPENDS} in p5 ports, except 2018-10-06 13:06:42 +00:00
p5-XML-WBXML
pear-Services_JSON
pecl-fribidi Fix some PKGNAME collisions 2018-10-08 15:08:13 +00:00
pecl-igbinary Update to 2.0.8 2018-10-21 16:48:58 +00:00
php56-iconv
php56-mbstring
php56-recode
php70-iconv
php70-mbstring
php70-recode
php71-iconv
php71-mbstring Update to 7.1.24 2018-11-15 16:40:59 +00:00
php71-recode
php72-iconv
php72-mbstring Update to 7.2.12 2018-11-10 17:33:27 +00:00
php72-recode
php73-iconv Add PHP 7.3 RC2 to the ports-tree. 2018-10-08 08:52:51 +00:00
php73-mbstring Add PHP 7.3 RC2 to the ports-tree. 2018-10-08 08:52:51 +00:00
php73-recode Add PHP 7.3 RC2 to the ports-tree. 2018-10-08 08:52:51 +00:00
php-bsdconv
psiconv
py-bcode Reset maintainer on my python ports 2018-10-02 19:06:16 +00:00
py-bencode.py
py-bencoder
py-better-bencode
py-bsdconv
py-iconv
py-pint
py-rencode converters/py-rencode: Fails to configure if cython is installed 2018-11-28 05:51:49 +00:00
py-text-unidecode text-unidecode is the most basic port of the Text::Unidecode Perl library. There 2018-07-28 12:03:06 +00:00
py-unidecode converters/py-unidecode: Update to 1.0.23 2018-11-25 19:51:37 +00:00
py-webencodings
py-zfec Update pkg-descr and WWW 2018-08-22 21:45:59 +00:00
R-cran-base64enc
R-cran-jsonlite
R-cran-rjson
R-cran-RJSONIO - Update to 1.3-1.1 2018-11-18 05:42:27 +00:00
rcctools
recode Install texinfo files (GNU info) into ${PREFIX}/share/info 2018-11-10 18:12:57 +00:00
rubygem-base32
rubygem-json-ld Update to 3.0.2 2018-09-22 16:45:08 +00:00
rubygem-json-ld-preloaded Update to 3.0.1 2018-09-10 20:28:22 +00:00
rubygem-po_to_json
rubygem-ruby-bsdconv
rubygem-url_safe_base64
rubygem-xdr
shftool
showkey
ta2as
tnef
trans
tuc
unix2dos
uudeview
uulib Add DOCS options to ports that should have one. 2018-09-10 13:14:50 +00:00
vda2fbd
wkhtmltopdf security/openssl-devel was removed, but there is a security/openssl111 now. 2018-11-10 10:09:48 +00:00
xdeview
xml2c
ytnef
zbase32
Makefile Connect all the PHP 7.3 ports 2018-10-08 09:31:09 +00:00