1
0
mirror of https://git.FreeBSD.org/ports.git synced 2025-01-03 06:04:53 +00:00
freebsd-ports/irc/dxirc/Makefile
Tijl Coosemans 1bf487d3e7 Fix Qt5 symbol version scripts to put the catch-all clause first. When
a symbol matches multiple clauses the last one takes precedence.  If the
catch-all is last it captures everything.  In the case of Qt5 libraries
this caused all symbols to have a Qt_5 label while some should have
Qt_5_PRIVATE_API.  This only affects lld because GNU ld always gives the
catch-all lowest priority.

Older versions of Qt5Webengine exported some memory allocation symbols from
the bundled Chromium.  Version 5.9 stopped exporting these [1] but the
symbols were kept as weak wrappers for the standard allocation functions to
maintain binary compatibility. [2][3]  The problem is that the call to the
standard function in these weak wrappers is only resolved to the standard
function if there's a call to this standard function in other parts of
Qt5Webengine, because only then is there a non-weak symbol that takes
precedence over the weak one.  If there's no such non-weak symbol the call
in the weak wrapper resolves to the weak wrapper itself creating an infinite
call loop that overflows the stack and causes a crash.  Some of the
allocation functions are variants of C++ new and delete and it probably
depends on the compiler whether these variants are used in other parts of
Qt5Webengine.

Remove the weak wrappers (make them Linux specific).  This isn't binary
compatible but we are already breaking that with the changes to the symbol
versions.

[1] 5c2cbfccf9
[2] 2ed5054e3a
[3] 009f5ebb4b

Bump all ports that depend on Qt5.

PR:		234070
Exp-run by:	antoine
Approved by:	kde (adridg)
2019-01-16 11:13:44 +00:00

62 lines
1.4 KiB
Makefile

# $FreeBSD$
PORTNAME= dxirc
PORTVERSION= 1.30.0
PORTREVISION= 1
CATEGORIES= irc ipv6
MASTER_SITES= SF/${PORTNAME}/${PORTVERSION}
MAINTAINER= arch_dvx@users.sourceforge.net
COMMENT= Simple IRC client
LICENSE= GPLv3+
LICENSE_FILE= ${WRKSRC}/COPYING
USE_XORG= ice sm x11 xext
USES= cmake pkgconfig
INSTALLS_ICONS= yes
OPTIONS_DEFINE= NLS LUA ENCHANT NOTIFY
OPTIONS_SINGLE= GUI
OPTIONS_SINGLE_GUI= FOX16 QT4 QT5
OPTIONS_DEFAULT= LUA QT5
OPTIONS_SUB= yes
ENCHANT_DESC= Spell checking support via Enchant
ENCHANT_LIB_DEPENDS= libenchant.so:textproc/enchant
ENCHANT_CMAKE_BOOL= HAVE_ENCHANT
FOX16_DESC= FOX 1.6 toolkit support
FOX16_LIB_DEPENDS= libFOX-1.6.so:x11-toolkits/fox16
FOX16_USES= ssl
FOX16_CMAKE_ON= -DFOX_ENABLE_IPV6:BOOL=ON \
-DBUILD_FOX:BOOL=ON -DBUILD_QT:BOOL=OFF
FOX16_CMAKE_OFF= -DBUILD_FOX:BOOL=OFF -DBUILD_QT:BOOL=ON
LUA_USES= lua
LUA_CMAKE_BOOL= WITH_LUA
NLS_USES= gettext
NLS_CMAKE_BOOL= WITH_NLS
NOTIFY_RUN_DEPENDS= notify-send:devel/libnotify
QT4_USES= qt:4
QT4_USE= QT=corelib,gui,network \
QT=moc_build,rcc_build,uic_build,qmake_build
QT4_CMAKE_ON= -DQT5:BOOL=OFF
QT5_USES= qt:5
QT5_USE= QT=core,gui,multimedia,network,widgets \
QT=buildtools_build,qmake_build
QT5_CMAKE_ON= -DQT5:BOOL=ON
.include <bsd.port.options.mk>
.if ${PORT_OPTIONS:MQT4}
DEPRECATED= Qt4 has been EOL since december 2015
EXPIRATION_DATE= 2019-03-15
.endif
.include <bsd.port.mk>