mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-16 10:20:30 +00:00
Code Issues Releases Activity

Simply error handling by moving the allocation of np down to where it is

Browse Source 
actually used.  While here, improve style a little.

Submitted by:	mjg
MFC after:	2 weeks
This commit is contained in:
Christian Brueffer 2012-07-16 22:07:29 +00:00
parent cfbd0d18bb
commit 01cc0b6531
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=238539
1 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sys/fs/smbfs/smbfs_node.c
View File

@ -223,17 +223,15 @@ smbfs_node_alloc(struct mount *mp, struct vnode *dvp,
if (fap == NULL)
return ENOENT;
np = malloc(sizeof *np, M_SMBNODE, M_WAITOK | M_ZERO);
error = getnewvnode("smbfs", mp, &smbfs_vnodeops, &vp);
if (error) {
free(np, M_SMBNODE);
return error;
}
error = insmntque(vp, mp); /* XXX: Too early for mpsafe fs */
if (error != 0) {
free(np, M_SMBNODE);
if (error != 0)
return (error);
}
error = insmntque(vp, mp); /* XXX: Too early for mpsafe fs */
if (error != 0)
return (error);
np = malloc(sizeof *np, M_SMBNODE, M_WAITOK | M_ZERO);
vp->v_type = fap->fa_attr & SMB_FA_DIR ? VDIR : VREG;
vp->v_data = np;
np->n_vnode = vp;