mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-25 11:37:56 +00:00
Code Issues Releases Activity

Don't send uninitialized memory (two instances of 4 bytes) in

Browse Source 
every cookie on the wire. This bug was reported in
https://bugzilla.mozilla.org/show_bug.cgi?id=905080

MFC after: 3 days
This commit is contained in:
Michael Tuexen 2013-08-14 21:51:32 +00:00
parent 93c5875b24
commit 0e05fbded9
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=254338
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/netinet/sctp_output.c
View File

@ -5406,6 +5406,14 @@ sctp_send_initiate_ack(struct sctp_inpcb *inp, struct sctp_tcb *stcb,
}
SCTP_BUF_LEN(m) = sizeof(struct sctp_init_chunk);
/*
* We might not overwrite the identification[] completely and on
* some platforms time_entered will contain some padding. Therefore
* zero out the cookie to avoid putting uninitialized memory on the
* wire.
*/
memset(&stc, 0, sizeof(struct sctp_state_cookie));
/* the time I built cookie */
(void)SCTP_GETTIME_TIMEVAL(&stc.time_entered);