mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-11-24 07:40:52 +00:00
Code Issues Releases Activity

os-release: Quote variables as documented in the manual

Browse Source 
Variables must be quoted if they contain non-alphanumeric characters.

Warner noted in the review that the lack of quoting causing problems
here is rather an edge case. I believe that it's worth adding the quotes
here anyway because this is what the specification says and there is no
good reason not to follow it.

Reviewed by:	imp
Approved by:	imp (src)
MFC after:	7 days
This commit is contained in:
Mateusz Piotrowski 2021-11-23 11:26:47 +01:00
parent 1cd0117ff6
commit 169e06fa78
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
libexec/rc/rc.d/os-release
View File

@ -27,14 +27,14 @@ osrelease_start()
t=$(mktemp -t os-release)
cat > "$t" <<-__EOF__
NAME=FreeBSD
VERSION=$_version
VERSION_ID=$_version_id
VERSION="$_version"
VERSION_ID="$_version_id"
ID=freebsd
ANSI_COLOR="0;31"
PRETTY_NAME="FreeBSD $_version"
CPE_NAME=cpe:/o:freebsd:freebsd:$_version_id
HOME_URL=https://FreeBSD.org/
BUG_REPORT_URL=https://bugs.FreeBSD.org/
CPE_NAME="cpe:/o:freebsd:freebsd:$_version_id"
HOME_URL="https://FreeBSD.org/"
BUG_REPORT_URL="https://bugs.FreeBSD.org/"
__EOF__
install -C -o root -g wheel -m ${osrelease_perms} "$t" "${osrelease_file}"
rm -f "$t"