mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-22 11:17:19 +00:00
Code Issues Releases Activity

vt(4): Remove "FIXME" about multiple locking of vt_buf in vt_flush()

Browse Source 
After some testing, it appears that acquiring the lock once and keeping
it longer is slower than taking it multiple times.

While here, fix a typo in another comment.

MFC after:	1 week
This commit is contained in:
Jean-Sébastien Pédron 2014-08-22 17:49:24 +00:00
parent 82276bbb00
commit 1f9c1db5f5
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=270343
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/dev/vt/vt_core.c
View File

@ -428,7 +428,7 @@ vt_scroll(struct vt_window *vw, int offset, int whence)
diff = vthistory_seek(&vw->vw_buf, offset, whence);
/*
* Offset changed, please update Nth lines on sceen.
* Offset changed, please update Nth lines on screen.
* +N - Nth lines at top;
* -N - Nth lines at bottom.
*/
@ -903,12 +903,7 @@ vt_flush(struct vt_device *vd)
!(vw->vw_flags & VWF_MOUSE_HIDE)) { /* Cursor displayed. */
if (vd->vd_moldx != vd->vd_mx ||
vd->vd_moldy != vd->vd_my) {
/*
* Mark last mouse position as dirty to erase.
*
* FIXME: The vt_buf lock is acquired twice in a
* row.
*/
/* Mark last mouse position as dirty to erase. */
vt_mark_mouse_position_as_dirty(vd,
vd->vd_moldx, vd->vd_moldy);