mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-11-25 07:49:18 +00:00
Code Issues Releases Activity

igc: Remove a bogus register write in igc_if_queues_free()

Browse Source 
As explained in PR 277038, iflib calls IFDI_DETACH() and then
IFDI_QUEUES_FREE().  With igc, the latter writes to a register after it
has been unmapped.

igc_if_detach() already calls igc_release_hw_control(), and looking at
callers of igc_if_queues_free(), that appears to be sufficient.  So,
just remove the igc_release_hw_control() call.

PR:		277038
Reported by:	Mike Belanger <mibelanger@qnx.com>
Reviewed by:	kbowling
Tested by:	kbowling
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D47293
This commit is contained in:
Mark Johnston 2024-10-26 21:04:59 +00:00
parent 20b823a59b
commit 35d05a14ed
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/dev/igc/if_igc.c
View File

@ -2050,8 +2050,6 @@ igc_if_queues_free(if_ctx_t ctx)
sc->rx_queues = NULL;
}
igc_release_hw_control(sc);
if (sc->mta != NULL) {
free(sc->mta, M_DEVBUF);
}