1
0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-02 08:42:48 +00:00

efi-autoresizecons: Don't fail the boot w/o GOP or UGA

efi-autoresizecons is currently executed for every boot. If it fails, we
risk failing the boot, and we really shouldn't do that unless we absolutely
must.

Not being able to locate GOP or UGA is not a significant enough failure to
kill the boot. We always have the option to fall back to resizing ConOut to
a higher text mode resolution (if available), so do that.

This was detected by Doug [1] while attempting a bhyve + UEFI + PXE boot.
This patch was effectively also submitted by Doug, but I expanded the
comment he had originally sent me a little bit to indicate why this is an OK
idea.

Reported by:	Doug Ambrisko <ambrisko@ambrisko.com> [1]
This commit is contained in:
Kyle Evans 2018-08-04 06:40:18 +00:00
parent 1856c32ef6
commit 37528fb4fb
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=337285

View File

@ -648,7 +648,14 @@ command_autoresize(int argc, char *argv[])
snprintf(command_errbuf, sizeof(command_errbuf),
"%s: Neither Graphics Output Protocol nor Universal Graphics Adapter present",
argv[0]);
return (CMD_ERROR);
/*
* Default to text_autoresize if we have neither GOP or UGA. This won't
* give us the most ideal resolution, but it will at least leave us
* functional rather than failing the boot for an objectively bad
* reason.
*/
return (text_autoresize());
}
COMMAND_SET(gop, "gop", "graphics output protocol", command_gop);