mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-29 12:03:03 +00:00
Code Issues Releases Activity

vfs: tidy up assertions in vfs_subr

Browse Source 
- assert unlocked vnode interlock in vref
- assert right counts in vputx
- print debug info for panic in vdrop

Sponsored by:	The FreeBSD Foundation
This commit is contained in:
Mateusz Guzik 2019-08-30 00:45:53 +00:00
parent d676fedfbc
commit 3bb8d8d8c9
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=351622
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sys/kern/vfs_subr.c
View File

@ -2778,6 +2778,7 @@ void
vref(struct vnode *vp)
{
ASSERT_VI_UNLOCKED(vp, __func__);
CTR2(KTR_VFS, "%s: vp %p", __func__, vp);
_vhold(vp, false);
v_incr_usecount(vp);
@ -2853,6 +2854,9 @@ vputx(struct vnode *vp, int func)
else
KASSERT(func == VPUTX_VRELE, ("vputx: wrong func"));
ASSERT_VI_UNLOCKED(vp, __func__);
VNASSERT(vp->v_holdcnt > 0 && vp->v_usecount > 0, vp,
("%s: wrong ref counts", __func__));
CTR2(KTR_VFS, "%s: vp %p", __func__, vp);
if (vp->v_type != VCHR &&
@ -3069,8 +3073,10 @@ _vdrop(struct vnode *vp, bool locked)
else
ASSERT_VI_UNLOCKED(vp, __func__);
CTR2(KTR_VFS, "%s: vp %p", __func__, vp);
if ((int)vp->v_holdcnt <= 0)
panic("vdrop: holdcnt %d", vp->v_holdcnt);
if (__predict_false((int)vp->v_holdcnt <= 0)) {
vn_printf(vp, "vdrop: holdcnt %d", vp->v_holdcnt);
panic("vdrop: wrong holdcnt");
}
if (!locked) {
if (refcount_release_if_not_last(&vp->v_holdcnt))
return;