mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-20 11:11:24 +00:00
Code Issues Releases Activity

acpi_cpu_cx_list: there is no need to re-evaluate cpu_non_c3 here

Browse Source 
cpu_non_c3 is already evaluated in acpi_cpu_cx_cst and in
acpi_cpu_set_cx_lowest.
Besides acpi_cpu_cx_list is not protected by any locking.

As a result also move setting of cpu_can_deep_sleep to more appropriate
places.

MFC after:	2 weeks
This commit is contained in:
Andriy Gapon 2012-07-07 08:12:51 +00:00
parent 56101001b2
commit 412ef22084
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=238193
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
sys/dev/acpica/acpi_cpu.c
View File

@ -670,6 +670,7 @@ acpi_cpu_generic_cx_probe(struct acpi_cpu_softc *sc)
cx_ptr->trans_lat = AcpiGbl_FADT.C3Latency;
cx_ptr++;
sc->cpu_cx_count++;
cpu_can_deep_sleep = 1;
}
}
}
@ -761,7 +762,8 @@ acpi_cpu_cx_cst(struct acpi_cpu_softc *sc)
"acpi_cpu%d: C3[%d] not available.\n",
device_get_unit(sc->cpu_dev), i));
continue;
}
} else
cpu_can_deep_sleep = 1;
break;
}
@ -885,16 +887,10 @@ acpi_cpu_cx_list(struct acpi_cpu_softc *sc)
/*
* Set up the list of Cx states
*/
sc->cpu_non_c3 = 0;
sbuf_new(&sb, sc->cpu_cx_supported, sizeof(sc->cpu_cx_supported),
SBUF_FIXEDLEN);
for (i = 0; i < sc->cpu_cx_count; i++) {
for (i = 0; i < sc->cpu_cx_count; i++)
sbuf_printf(&sb, "C%d/%d ", i + 1, sc->cpu_cx_states[i].trans_lat);
if (sc->cpu_cx_states[i].type < ACPI_STATE_C3)
sc->cpu_non_c3 = i;
else
cpu_can_deep_sleep = 1;
}
sbuf_trim(&sb);
sbuf_finish(&sb);
}