mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-17 10:26:15 +00:00
Code Issues Releases Activity

Fixed panics in apic interrupt handlers if kernel profiling is turned

Browse Source 
on.  MCOUNT and FAKE_MCOUNT() may clobber all the call-used registers,
and one FAKE_MCOUNT() was placed so that an active %eax was clobbered.
The fix is to move this FAKE_MCOUNT() earlier where it should have
been anyway.

Fixed 3 layers of bitrot in the comment about why this FAKE_MCOUNT()
was where it was by removing the comment.  (mcount() should be called
as early as possible after entering a new level, but an implementation
detail got in the way until 3 layers of changes ago.)

Kernel profiling still gives wrong results because the new interrupt
code rearranged object files too much.  mcount() depends on trap,
syscall and interrupt handlers being between certain magic labels with
interrupt handlers last, and on nothing else being there.  Splitting
up exception.o moved the magic labels to effectively random places
relative to what they are supposed to delimit.  This mainly broke the
call graph; the flat profile is still usable.
This commit is contained in:
Bruce Evans 2003-12-02 15:02:12 +00:00
parent fb0ca10d0c
commit 4e72678dee
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=123106
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/i386/i386/apic_vector.s
View File

@ -81,13 +81,13 @@ IDTVEC(vec_name) ; \
mov %ax, %es ; \ mov %ax, %es ; \
movl $KPSEL, %eax ; /* reload with per-CPU data segment */ \ movl $KPSEL, %eax ; /* reload with per-CPU data segment */ \
mov %ax, %fs ; \ mov %ax, %fs ; \
FAKE_MCOUNT(13*4(%esp)) ; \
movl lapic, %edx ; /* pointer to local APIC */ \ movl lapic, %edx ; /* pointer to local APIC */ \
movl LA_ISR + 16 * (index)(%edx), %eax ; /* load ISR */ \ movl LA_ISR + 16 * (index)(%edx), %eax ; /* load ISR */ \
bsrl %eax, %eax ; /* index of highset set bit in ISR */ \ bsrl %eax, %eax ; /* index of highset set bit in ISR */ \
jz 2f ; \ jz 2f ; \
addl $(32 * index),%eax ; \ addl $(32 * index),%eax ; \
1: ; \ 1: ; \
FAKE_MCOUNT(13*4(%esp)) ; /* XXX avoid double count */ \
pushl %eax ; /* pass the IRQ */ \ pushl %eax ; /* pass the IRQ */ \
call lapic_handle_intr ; \ call lapic_handle_intr ; \
addl $4, %esp ; /* discard parameter */ \ addl $4, %esp ; /* discard parameter */ \