mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-15 10:17:20 +00:00
Code Issues Releases Activity

Mark two places where an unsigned number is checked "if (foo < 0)" with

Browse Source 
an XXX comment.

Somebody[TM] should look at this in some detail.

Spotted by:	FlexeLint
This commit is contained in:
Poul-Henning Kamp 2002-10-02 09:11:18 +00:00
parent 8c5d013757
commit 4f3ee6dcc4
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=104364
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
sys/ufs/ufs/ufs_quota.c
View File

@ -254,6 +254,7 @@ chkiq(ip, change, cred, flags)
#endif
if (change == 0)
return (0);
/* XXX: change is unsigned */
if (change < 0) {
for (i = 0; i < MAXQUOTAS; i++) {
if ((dq = ip->i_dquot[i]) == NODQUOT)
@ -263,6 +264,7 @@ chkiq(ip, change, cred, flags)
(void) tsleep((caddr_t)dq, PINOD+1, "chkiq1", 0);
}
ncurinodes = dq->dq_curinodes + change;
/* XXX: ncurinodes is unsigned */
if (ncurinodes >= 0)
dq->dq_curinodes = ncurinodes;
else