mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-26 16:18:31 +00:00
Code Issues Releases Activity

Use sbufs instead of snprintf for parsing debug strings.

Browse Source
This commit is contained in:
Nate Lawson 2003-12-09 06:29:57 +00:00
parent b5a8abc730
commit 54f6bca07c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=123337
1 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
sys/dev/acpica/acpi.c
View File

@ -43,6 +43,7 @@
#include <sys/ctype.h>
#include <sys/linker.h>
#include <sys/power.h>
#include <sys/sbuf.h>
#include <machine/clock.h>
#include <machine/resource.h>
@ -2263,14 +2264,12 @@ SYSINIT(acpi_debugging, SI_SUB_TUNABLES, SI_ORDER_ANY, acpi_set_debugging,
static int
acpi_debug_sysctl(SYSCTL_HANDLER_ARGS)
{
char *options;
int error, len, *dbg;
int error, *dbg;
struct debugtag *tag;
struct sbuf sb;
len = 512;
MALLOC(options, char *, len, M_TEMP, M_WAITOK);
options[0] = '\0';
if (sbuf_new(&sb, NULL, 128, SBUF_AUTOEXTEND) == NULL)
return (ENOMEM);
if (strcmp(oidp->oid_arg1, "debug.acpi.layer") == 0) {
tag = &dbg_layer[0];
dbg = &AcpiDbgLayer;
@ -2281,17 +2280,18 @@ acpi_debug_sysctl(SYSCTL_HANDLER_ARGS)
/* Get old values if this is a get request. */
if (*dbg == 0) {
strlcpy(options, "NONE", sizeof(options));
sbuf_cpy(&sb, "NONE");
} else if (req->newptr == NULL) {
for (; tag->name != NULL; tag++) {
if ((*dbg & tag->value) == tag->value) {
strlcat(options, tag->name, len);
strlcat(options, " ", len); /* XXX */
}
if ((*dbg & tag->value) == tag->value)
sbuf_printf(&sb, "%s ", tag->name);
}
}
sbuf_trim(&sb);
sbuf_finish(&sb);
error = sysctl_handle_string(oidp, options, len, req);
error = sysctl_handle_string(oidp, sbuf_data(&sb), sbuf_len(&sb), req);
sbuf_delete(&sb);
/* If the user is setting a string, parse it. */
if (error == 0 && req->newptr != NULL) {
@ -2299,7 +2299,6 @@ acpi_debug_sysctl(SYSCTL_HANDLER_ARGS)
setenv((char *)oidp->oid_arg1, (char *)req->newptr);
acpi_set_debugging(NULL);
}
FREE(options, M_TEMP);
return (error);
}