mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-19 15:33:56 +00:00
Code Issues Releases Activity

Be more like the BGE driver. Ensure that at least 16 TX descriptors are

Browse Source 
kept unused in the ring.  This check should probably be moved up to
bce_start_locked at some point, as it'll make the loop up there slightly
more efficient, and will eliminate a costly set of busdma operations when
the ring is full.  But this works for now.

This makes all of my UDP torture tests work.  I'll cautiously say that
it might even work for other users now.  Feedback is appreciated.
This commit is contained in:
Scott Long 2006-10-21 07:54:39 +00:00
parent 24ef8c83ee
commit 61a1e7e66d
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=163558
1 changed files with 11 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
sys/dev/bce/if_bce.c
View File

@ -4549,13 +4549,6 @@ bce_tx_encap(struct bce_softc *sc, struct mbuf **m_head)
chain_prod = TX_CHAIN_IDX(prod);
map = sc->tx_mbuf_map[chain_prod];
/*
* XXX This should be handled higher up.
*/
if ((USABLE_TX_BD - sc->used_tx_bd - BCE_TX_SLACK_SPACE) <= 0) {
return (ENOBUFS);
}
/* Map the mbuf into our DMA address space. */
error = bus_dmamap_load_mbuf_sg(sc->tx_mbuf_tag, map, m0,
segs, &nsegs, BUS_DMA_NOWAIT);
@ -4596,6 +4589,16 @@ bce_tx_encap(struct bce_softc *sc, struct mbuf **m_head)
return (error);
}
/*
* The chip seems to require that at least 16 descriptors be kept
* empty at all times. Make sure we honor that.
* XXX Would it be faster to assume worst case scenario for nsegs
* and do this calculation higher up?
*/
if (nsegs > (USABLE_TX_BD - sc->used_tx_bd - BCE_TX_SLACK_SPACE)) {
bus_dmamap_unload(sc->tx_mbuf_tag, map);
return (ENOBUFS);
}
/* prod points to an empty tx_bd at this point. */
prod_bseq = sc->tx_prod_bseq;
@ -4701,7 +4704,7 @@ bce_start_locked(struct ifnet *ifp)
__FUNCTION__, tx_prod, tx_chain_prod, sc->tx_prod_bseq);
/* Keep adding entries while there is space in the ring. */
while (!IFQ_DRV_IS_EMPTY(&ifp->if_snd)) {
while (sc->tx_mbuf_ptr[tx_chain_prod] == NULL) {
/* Check for any frames to send. */
IFQ_DRV_DEQUEUE(&ifp->if_snd, m_head);