mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-09 13:42:56 +00:00
Code Issues Releases Activity

Calculate the string length of a u_long at compile-time, instead of using a

Browse Source 
hardcoded value.
This commit is contained in:
Kris Kennaway 2000-08-04 11:07:57 +00:00
parent dec5f6ac42
commit 63c21920f9
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=64242
1 changed files with 18 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
lib/libc/rpc/netname.c
View File

@ -49,10 +49,11 @@ static char sccsid[] = "@(#)netname.c 1.8 91/03/11 Copyr 1986 Sun Micro";
#include <rpcsvc/ypclnt.h> #include <rpcsvc/ypclnt.h>
#endif #endif
#include <ctype.h> #include <ctype.h>
#include <stdlib.h> #include <limits.h>
#include <unistd.h>
#include <string.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h>
#include <string.h>
#include <unistd.h>
#ifndef MAXHOSTNAMELEN #ifndef MAXHOSTNAMELEN
#define MAXHOSTNAMELEN 256 #define MAXHOSTNAMELEN 256
@ -61,6 +62,19 @@ static char sccsid[] = "@(#)netname.c 1.8 91/03/11 Copyr 1986 Sun Micro";
#define NGROUPS 16 #define NGROUPS 16
#endif #endif
#define TYPE_BIT(type) (sizeof (type) * CHAR_BIT)
#define TYPE_SIGNED(type) (((type) -1) < 0)
/*
** 302 / 1000 is log10(2.0) rounded up.
** Subtract one for the sign bit if the type is signed;
** add one for integer division truncation;
** add one more for a minus sign if the type is signed.
*/
#define INT_STRLEN_MAXIMUM(type) \
((TYPE_BIT(type) - TYPE_SIGNED(type)) * 302 / 1000 + 1 + TYPE_SIGNED(type))
static char *OPSYS = "unix"; static char *OPSYS = "unix";
/* /*
@ -92,15 +106,13 @@ user2netname(netname, uid, domain)
{ {
char *dfltdom; char *dfltdom;
#define MAXIPRINT (20) /* max length of printed integer */
if (domain == NULL) { if (domain == NULL) {
if (_rpc_get_default_domain(&dfltdom) != 0) { if (_rpc_get_default_domain(&dfltdom) != 0) {
return (0); return (0);
} }
domain = dfltdom; domain = dfltdom;
} }
if (strlen(domain) + 1 + MAXIPRINT + 1 + strlen(OPSYS) > MAXNETNAMELEN) { if (strlen(domain) + 1 + INT_STRLEN_MAXIMUM(u_long) + 1 + strlen(OPSYS) > MAXNETNAMELEN) {
return (0); return (0);
} }
(void) sprintf(netname, "%s.%ld@%s", OPSYS, (u_long)uid, domain); (void) sprintf(netname, "%s.%ld@%s", OPSYS, (u_long)uid, domain);