mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-09 13:42:56 +00:00
Code Issues Releases Activity

Correct string length bounds checking.

Browse Source
This commit is contained in:
Kris Kennaway 2000-08-04 10:53:37 +00:00
parent 099d883225
commit 683544bd3e
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=64240
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/libc/rpc/netname.c
View File

@ -26,6 +26,8 @@
* Sun Microsystems, Inc.
* 2550 Garcia Avenue
* Mountain View, California 94043
*
* $FreeBSD$
*/
#if !defined(lint) && defined(SCCSIDS)
static char sccsid[] = "@(#)netname.c 1.8 91/03/11 Copyr 1986 Sun Micro";
@ -90,7 +92,7 @@ user2netname(netname, uid, domain)
{
char *dfltdom;
#define MAXIPRINT (11) /* max length of printed integer */
#define MAXIPRINT (20) /* max length of printed integer */
if (domain == NULL) {
if (_rpc_get_default_domain(&dfltdom) != 0) {
@ -98,7 +100,7 @@ user2netname(netname, uid, domain)
}
domain = dfltdom;
}
if (strlen(domain) + 1 + MAXIPRINT > MAXNETNAMELEN) {
if (strlen(domain) + 1 + MAXIPRINT + 1 + strlen(OPSYS) > MAXNETNAMELEN) {
return (0);
}
(void) sprintf(netname, "%s.%ld@%s", OPSYS, (u_long)uid, domain);
@ -128,7 +130,7 @@ host2netname(netname, host, domain)
(void) gethostname(hostname, sizeof(hostname));
host = hostname;
}
if (strlen(domain) + 1 + strlen(host) > MAXNETNAMELEN) {
if (strlen(domain) + 1 + strlen(host) + 1 + strlen(OPSYS) > MAXNETNAMELEN) {
return (0);
}
(void) sprintf(netname, "%s.%s@%s", OPSYS, host, domain);