mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-05 12:56:08 +00:00
Code Issues Releases Activity

mail: add volatile in grabh()

Browse Source 
setjmp() requires that any stack variables modified between the setjmp
call and the longjmp() must be volatile.  This means that 'saveint' in
grabh() must be volatile, since it's modified after the setjmp().
Otherwise, the signal handler is not properly restored, resulting in a
crash (SIGBUS) if ^C is typed twice while composing.

PR:		276119
Reported by:	Christopher Davidson <christopher.davidson@gmail.com>
MFC after:	2 weeks
Pull Request:	https://github.com/freebsd/freebsd-src/pull/993
This commit is contained in:
Lexi Winter 2024-01-04 22:34:58 +00:00 committed by Mark Johnston
parent 324fd7ec40
commit 6c951b3717
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
usr.bin/mail/tty.c
View File

@ -54,7 +54,7 @@ int
grabh(struct header *hp, int gflags)
{
struct termios ttybuf;
sig_t saveint;
volatile sig_t saveint;
sig_t savetstp;
sig_t savettou;
sig_t savettin;