1
0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-27 16:39:08 +00:00

Remember to unlock the (optional) vnode in vfs_stdextattrctl(). Failing

to do this made the following script hang:

	#!/bin/sh
	set -ex

	extattrctl start /tmp
	extattrctl initattr 64 /tmp/EA00
	extattrctl enable /tmp user ea00 /tmp/EA00
	extattrctl showattr /tmp/EA00

if the filesystem backing /tmp did not support EAs.

The real solution is probably to have the extattrctl syscall do the
unlocking rather than depend on the filesystem to do it.  Considering
that extattrctl is going to be made obsolete anyway, this has dogwash
priority.

Sponsored by:	DARPA & NAI Labs.
This commit is contained in:
Poul-Henning Kamp 2002-08-13 11:11:51 +00:00
parent f0134e3330
commit 6f21160218
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=101786

View File

@ -819,6 +819,8 @@ vfs_stdextattrctl(mp, cmd, filename_vp, attrnamespace, attrname, td)
const char *attrname;
struct thread *td;
{
if (filename_vp != NULL)
VOP_UNLOCK(filename_vp, 0, td);
return(EOPNOTSUPP);
}