mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-19 15:33:56 +00:00
Code Issues Releases Activity

Remove XXX comment that changes to file fields should be protected with

Browse Source 
the file lock rather than the filedesc lock: I fixed this in the last
revision.

Spotted by:	kris
This commit is contained in:
Robert Watson 2007-04-06 23:31:30 +00:00
parent 7d80a3b493
commit 7b20aa9ca6
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=168443
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/kern/uipc_syscalls.c
View File

@ -182,11 +182,6 @@ socket(td, uap)
if (error) {
fdclose(fdp, fp, fd, td);
} else {
/*
* XXXRW: The logic here seems wrong -- shouldn't it be
* locking the file, not the filedesc? Other threads could
* already have a reference to the socket by now.
*/
FILE_LOCK(fp);
fp->f_data = so; /* already has ref count */
fp->f_flag = FREAD|FWRITE;