1
0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-05 09:14:03 +00:00

Update a comment: It no longer makes sense to talk about the page queues

lock here.
This commit is contained in:
Alan Cox 2010-05-08 23:01:47 +00:00
parent 34e7251f10
commit 7d1d2ef60a
Notes: svn2git 2020-12-20 02:59:44 +00:00
svn path=/head/; revision=207805

View File

@ -767,13 +767,10 @@ pipe_build_write_buffer(wpipe, uio)
return (EFAULT); return (EFAULT);
for (i = 0; addr < endaddr; addr += PAGE_SIZE, i++) { for (i = 0; addr < endaddr; addr += PAGE_SIZE, i++) {
/* /*
* vm_fault_quick() can sleep. Consequently, * vm_fault_quick() can sleep.
* vm_page_lock_queue() and vm_page_unlock_queue()
* should not be performed outside of this loop.
*/ */
race: race:
if (vm_fault_quick((caddr_t)addr, VM_PROT_READ) < 0) { if (vm_fault_quick((caddr_t)addr, VM_PROT_READ) < 0) {
for (j = 0; j < i; j++) { for (j = 0; j < i; j++) {
vm_page_lock(wpipe->pipe_map.ms[j]); vm_page_lock(wpipe->pipe_map.ms[j]);
vm_page_unhold(wpipe->pipe_map.ms[j]); vm_page_unhold(wpipe->pipe_map.ms[j]);