mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-30 16:51:41 +00:00
Code Issues Releases Activity

Avoid undefined behavior when calling va_start() in bnep_send_control(),

Browse Source 
by making the 'type' parameter a plain unsigned.

MFC after:	3 days
This commit is contained in:
Dimitry Andric 2016-08-29 19:40:46 +00:00
parent 7c39d98bd3
commit 7fcdc815d2
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=305023
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
usr.sbin/bluetooth/btpand/bnep.c
View File

@ -574,7 +574,7 @@ bnep_recv_filter_multi_addr_rsp(channel_t *chan, uint8_t *ptr, size_t size)
}
void
bnep_send_control(channel_t *chan, uint8_t type, ...)
bnep_send_control(channel_t *chan, unsigned type, ...)
{
packet_t *pkt;
uint8_t *p;
@ -590,7 +590,7 @@ bnep_send_control(channel_t *chan, uint8_t type, ...)
va_start(ap, type);
*p++ = BNEP_CONTROL;
*p++ = type;
*p++ = (uint8_t)type;
switch(type) {
case BNEP_CONTROL_COMMAND_NOT_UNDERSTOOD:

2
usr.sbin/bluetooth/btpand/btpand.h
View File

@ -183,7 +183,7 @@ b2eaddr(void *dst, bdaddr_t *src)
/* bnep.c */
bool bnep_send(channel_t *, packet_t *);
bool bnep_recv(packet_t *);
void bnep_send_control(channel_t *, uint8_t, ...);
void bnep_send_control(channel_t *, unsigned, ...);
/* channel.c */
void channel_init(void);