mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-11 14:10:34 +00:00
Code Issues Releases Activity

Avoid a wakeup(9) if we can be sure no one is waiting on the task.

Browse Source 
Submitted by:       Matthew Fleming <matthew.fleming@isilon.com>
Reviewed by:        zml, jhb
This commit is contained in:
Zachary Loafman 2010-05-28 18:15:34 +00:00
parent 6e86cdb85c
commit 911de7741d
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=208624
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
sys/kern/subr_taskqueue.c
View File

@ -57,6 +57,7 @@ struct taskqueue {
int tq_spin;
int tq_flags;
int tq_tasks_running;
int tq_task_waiters;
};
#define TQ_FLAGS_ACTIVE (1 << 0)
@ -240,7 +241,8 @@ taskqueue_run(struct taskqueue *queue)
TQ_LOCK(queue);
queue->tq_tasks_running--;
wakeup(task);
if (queue->tq_task_waiters > 0)
wakeup(task);
}
/*
@ -256,15 +258,21 @@ taskqueue_drain(struct taskqueue *queue, struct task *task)
{
if (queue->tq_spin) { /* XXX */
mtx_lock_spin(&queue->tq_mutex);
while (task->ta_pending != 0 || queue->tq_tasks_running > 0)
while (task->ta_pending != 0 || queue->tq_tasks_running > 0) {
queue->tq_task_waiters++;
msleep_spin(task, &queue->tq_mutex, "-", 0);
queue->tq_task_waiters--;
}
mtx_unlock_spin(&queue->tq_mutex);
} else {
WITNESS_WARN(WARN_GIANTOK | WARN_SLEEPOK, NULL, __func__);
mtx_lock(&queue->tq_mutex);
while (task->ta_pending != 0 || queue->tq_tasks_running > 0)
while (task->ta_pending != 0 || queue->tq_tasks_running > 0) {
queue->tq_task_waiters++;
msleep(task, &queue->tq_mutex, PWAIT, "-", 0);
queue->tq_task_waiters--;
}
mtx_unlock(&queue->tq_mutex);
}
}