mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-05 12:56:08 +00:00
Code Issues Releases Activity

Filter out TESTS_SUBDIRS already added to SUBDIR instead of blindly

Browse Source 
appending the TESTS_SUBDIRS variable to SUBDIR

Duplicate directory entries can cause unexpected side effects, like
installing the same files multiple times. This can be easily
reproduced via the following testcase prior to this commit:

  SUBDIR= dir
  TESTS_SUBDIRS+= dir

  .include <bsd.test.mk>

Sponsored by: EMC / Isilon Storage Division
This commit is contained in:
Enji Cooper 2014-10-28 23:01:09 +00:00
parent 3fb51b3a43
commit 9aa9738938
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=273803
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
share/mk/bsd.test.mk
View File

@ -54,9 +54,11 @@ _TESTS=
.include <plain.test.mk>
.include <tap.test.mk>
.if !empty(TESTS_SUBDIRS)
SUBDIR+= ${TESTS_SUBDIRS}
.for ts in ${TESTS_SUBDIRS}
.if empty(SUBDIR:N${ts})
SUBDIR+= ${ts}
.endif
.endfor
# it is rare for test cases to have man pages
.if !defined(MAN)