mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-01 08:27:59 +00:00
Code Issues Releases Activity

Call umask() before opening the lock-file for a queue, to make sure

Browse Source 
the file will be created with the right access, if the call to open()
does create it.  Also fix the other call to umask() to turn off
"write others", just as a matter of general safety.

PR:		74418
MFC after:	4 days
This commit is contained in:
Garance A Drosehn 2004-12-19 05:14:29 +00:00
parent 5f1f4b0908
commit a6ed151d3c
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=139035
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
usr.sbin/lpr/lpd/printjob.c
View File

@ -202,6 +202,7 @@ printjob(struct printer *pp)
}
if (stat(pp->lock_file, &stb) == 0 && (stb.st_mode & LFM_PRINT_DIS))
exit(0); /* printing disabled */
umask(S_IWOTH);
lfd = open(pp->lock_file, O_WRONLY|O_CREAT|O_EXLOCK|O_NONBLOCK,
LOCK_FILE_MODE);
if (lfd < 0) {
@ -1974,7 +1975,7 @@ pstatus(const struct printer *pp, const char *msg, ...)
va_list ap;
va_start(ap, msg);
umask(0);
umask(S_IWOTH);
fd = open(pp->status_file, O_WRONLY|O_CREAT|O_EXLOCK, STAT_FILE_MODE);
if (fd < 0) {
syslog(LOG_ERR, "%s: open(%s): %m", pp->printer,