mirror of
https://git.FreeBSD.org/src.git
synced 2024-12-05 09:14:03 +00:00
Wrap calls to memcpy(3) in a function called block_copy(). This way,
and as long as we're not compiling with IPA, gcc(1) won't optimize the call away. The whole purpose of using memcpy(3) is to avoid misaligned loads and stores when we need to read or write the value in the unaligned memory location. But if gcc(1) optimizes the call to memcpy(3) away, it will typically introduce misaligned loads and stores. In this context that's not a good idea.
This commit is contained in:
parent
c1195b0646
commit
ad284e38a3
Notes:
svn2git
2020-12-20 02:59:44 +00:00
svn path=/head/; revision=140922
@ -101,6 +101,13 @@ DATA_TYPE *aligned = &data.aligned;
|
||||
DATA_TYPE *misaligned = (DATA_TYPE *)data.misaligned;
|
||||
DATA_TYPE value = DATA_VALUE;
|
||||
|
||||
void
|
||||
block_copy(void *dst, void *src, size_t sz)
|
||||
{
|
||||
|
||||
memcpy(dst, src, sz);
|
||||
}
|
||||
|
||||
int
|
||||
main()
|
||||
{
|
||||
@ -112,7 +119,7 @@ main()
|
||||
/*
|
||||
* LOAD
|
||||
*/
|
||||
memcpy(misaligned, &value, sizeof(DATA_TYPE));
|
||||
block_copy(misaligned, &value, sizeof(DATA_TYPE));
|
||||
|
||||
# if POSTINC == NoPostInc
|
||||
/* Misaligned load. */
|
||||
@ -179,7 +186,7 @@ main()
|
||||
return (1);
|
||||
# endif
|
||||
|
||||
memcpy(aligned, data.misaligned, sizeof(DATA_TYPE));
|
||||
block_copy(aligned, data.misaligned, sizeof(DATA_TYPE));
|
||||
#endif
|
||||
|
||||
if (*aligned != value)
|
||||
|
Loading…
Reference in New Issue
Block a user