mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-20 15:43:16 +00:00
Code Issues Releases Activity

Fix a race condition by initializing the taskqueue before registering

Browse Source 
the fast interrupt handler that uses it.  This fixes a panic at boot
time when em_intr_fast() calls taskqueue_enqueue().
This commit is contained in:
Maxime Henrion 2006-01-22 01:06:55 +00:00
parent a2b31c5b4f
commit b337232591
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=154663
1 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
sys/dev/em/if_em.c
View File

@ -2014,18 +2014,18 @@ em_allocate_intr(struct adapter *adapter)
* ithread.
*/
#ifndef NO_EM_FASTINTR
/* Init the deferred processing contexts. */
TASK_INIT(&adapter->rxtx_task, 0, em_handle_rxtx, adapter);
TASK_INIT(&adapter->link_task, 0, em_handle_link, adapter);
adapter->tq = taskqueue_create_fast("em_taskq", M_NOWAIT,
taskqueue_thread_enqueue, &adapter->tq);
taskqueue_start_threads(&adapter->tq, 1, PI_NET, "%s taskq",
device_get_nameunit(adapter->dev));
if (bus_setup_intr(dev, adapter->res_interrupt,
INTR_TYPE_NET | INTR_FAST, em_intr_fast, adapter,
&adapter->int_handler_tag) == 0) {
/* Init the deferred processing contexts. */
TASK_INIT(&adapter->rxtx_task, 0, em_handle_rxtx, adapter);
TASK_INIT(&adapter->link_task, 0, em_handle_link, adapter);
adapter->tq = taskqueue_create_fast("em_taskq", M_NOWAIT,
taskqueue_thread_enqueue,
&adapter->tq);
taskqueue_start_threads(&adapter->tq, 1, PI_NET, "%s taskq",
device_get_nameunit(adapter->dev));
&adapter->int_handler_tag) != 0) {
taskqueue_free(adapter->tq);
adapter->tq = NULL;
}
#endif
if (adapter->int_handler_tag == NULL) {