mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-10-20 02:38:43 +00:00
Code Issues Releases Activity

- ng_address_ID() has already freed the message, don't do double free.

Browse Source 
- Get error from ng_address_ID().

Reported by:	Coverity via pjd
This commit is contained in:
Gleb Smirnoff 2006-10-17 10:59:39 +00:00
parent dfa8edfec6
commit c6964951c6
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=163460
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
sys/netgraph/netgraph.h
View File

@ -962,17 +962,13 @@ _ngi_hook(item_p item, char *file, int line)
ng_ID_t _dest = NGI_RETADDR(item); \ ng_ID_t _dest = NGI_RETADDR(item); \
NGI_RETADDR(item) = 0; \ NGI_RETADDR(item) = 0; \
NGI_MSG(item) = resp; \ NGI_MSG(item) = resp; \
if ((ng_address_ID((here), (item), \ if ((error = ng_address_ID((here), (item), \
_dest, 0)) == 0) { \ _dest, 0)) == 0) { \
SAVE_LINE(item); \ SAVE_LINE(item); \
(error) = ng_snd_item((item), NG_QUEUE);\ (error) = ng_snd_item((item), NG_QUEUE);\
} else { \
NG_FREE_ITEM(item); \
(error) = EINVAL; \
} \ } \
} else { \ } else \
NG_FREE_ITEM(item); \ NG_FREE_ITEM(item); \
} \
(item) = NULL; \ (item) = NULL; \
} while (0) } while (0)