mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-15 15:06:42 +00:00
Code Issues Releases Activity

Verify if a label doesn't point to the parent directory.

Browse Source
This commit is contained in:
Pawel Jakub Dawidek 2006-08-12 15:30:24 +00:00
parent dbb78f2906
commit d88fe2bfc7
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=161245
1 changed files with 24 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
sys/geom/label/g_label.c
View File

@ -36,6 +36,7 @@ __FBSDID("$FreeBSD$");
#include <sys/bio.h>
#include <sys/sysctl.h>
#include <sys/malloc.h>
#include <sys/libkern.h>
#include <geom/geom.h>
#include <geom/geom_slice.h>
#include <geom/label/g_label.h>
@ -116,6 +117,23 @@ g_label_spoiled(struct g_consumer *cp)
g_slice_spoiled(cp);
}
static int
g_label_is_name_ok(const char *label)
{
const char *s;
/* Check is the label starts from ../ */
if (strncmp(label, "../", 3) == 0)
return (0);
/* Check is the label contains /../ */
if (strstr(label, "/../") != NULL)
return (0);
/* Check is the label ends at ../ */
if ((s = strstr(label, "/..")) != NULL && s[3] == '\0')
return (0);
return (1);
}
static struct g_geom *
g_label_create(struct gctl_req *req, struct g_class *mp, struct g_provider *pp,
const char *label, const char *dir, off_t mediasize)
@ -127,6 +145,12 @@ g_label_create(struct gctl_req *req, struct g_class *mp, struct g_provider *pp,
g_topology_assert();
if (!g_label_is_name_ok(label)) {
G_LABEL_DEBUG(0, "%s contains suspicious label, skipping.",
pp->name);
G_LABEL_DEBUG(1, "%s suspicious label is: %s", pp->name, label);
return (NULL);
}
gp = NULL;
cp = NULL;
snprintf(name, sizeof(name), "%s/%s", dir, label);