mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-18 10:35:55 +00:00
Code Issues Releases Activity

Fix the root cause of the "vm_reserv_populate: reserv <address> is already

Browse Source 
promoted" panics.  The sequence of events that leads to a panic is rather
long and circuitous.  First, suppose that process P has a promoted
superpage S within vm object O that it can write to.  Then, suppose that P
forks, which leads to S being write protected.  Now, before P's child
exits, suppose that P writes to another virtual page within O.  Since the
pages within O are copy on write, a shadow object for O is created to
house the new physical copy of the faulted on virtual page.  Then, before
P can fault on S, P's child exists.  Now, when P faults on S, it will
follow the "optimized" path for copy-on-write faults in vm_fault(),
wherein the underlying physical page is moved from O to its shadow object
rather than allocating a new page and copying the new page's contents from
the old page.  Moreover, suppose that every 4 KB physical page making up S
is moved to the shadow object in this way.  However, the optimized path
does not move the underlying superpage reservation, which is the root
cause of the panics!  Ultimately, P performs vm_object_collapse() on O's
shadow object, which destroys O and in doing so breaks any reservations
still belonging to O.  This leaves the reservation underlying S in an
inconsistent state: It's simultaneously not in use and promoted.  Breaking
a reservation does not demote it because I never intended for a promoted
reservation to be broken.  It makes little sense.  Finally, this
inconsistency leads to an assertion failure the next time that the
reservation is used.

The failing assertion does not (currently) exist in FreeBSD 10.x or
earlier.  There, we will quietly break the promoted reservation.  While
illogical and unintended, breaking the reservation is essentially
harmless.

PR:		198163
Reviewed by:	kib
Tested by:	pho
X-MFC after:	r267213
Sponsored by:	EMC / Isilon Storage Division
This commit is contained in:
Alan Cox 2015-03-19 01:40:43 +00:00
parent d0a8b2a5ae
commit dfdf9abd94
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=280238
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
sys/vm/vm_fault.c
View File

@ -101,6 +101,7 @@ __FBSDID("$FreeBSD$");
#include <vm/vm_kern.h> #include <vm/vm_kern.h>
#include <vm/vm_pager.h> #include <vm/vm_pager.h>
#include <vm/vm_extern.h> #include <vm/vm_extern.h>
#include <vm/vm_reserv.h>
#define PFBAK 4 #define PFBAK 4
#define PFFOR 4 #define PFFOR 4
@ -858,6 +859,14 @@ RetryFault:;
unlock_and_deallocate(&fs); unlock_and_deallocate(&fs);
goto RetryFault; goto RetryFault;
} }
#if VM_NRESERVLEVEL > 0
/*
* Rename the reservation.
*/
vm_reserv_rename(fs.m, fs.first_object,
fs.object, OFF_TO_IDX(
fs.first_object->backing_object_offset));
#endif
vm_page_xbusy(fs.m); vm_page_xbusy(fs.m);
fs.first_m = fs.m; fs.first_m = fs.m;
fs.m = NULL; fs.m = NULL;