mirror of
https://git.FreeBSD.org/src.git
synced 2024-10-19 02:29:40 +00:00
path_test: fix cap_rights_init usage
Capability rights passed to cap_rights_* are not simple bitmaks and cannot be ORed together in general (although it will work for certain subsets of rights). PR: 277057 Fixes:e5e1d9c7b7
("path_test: Add a test case for...") Sponsored by: The FreeBSD Foundation (cherry picked from commit8d1348f55a
) (cherry picked from commitea3910c452
)
This commit is contained in:
parent
ec44cc4e28
commit
e8d01b2efa
@ -235,7 +235,7 @@ ATF_TC_BODY(path_capsicum_empty, tc)
|
||||
/*
|
||||
* CAP_READ and CAP_LOOKUP should be sufficient to open a directory.
|
||||
*/
|
||||
cap_rights_init(&rights, CAP_READ | CAP_LOOKUP);
|
||||
cap_rights_init(&rights, CAP_READ, CAP_LOOKUP);
|
||||
ATF_REQUIRE(cap_rights_limit(pathdfd, &rights) == 0);
|
||||
dfd = openat(pathdfd, "", O_DIRECTORY | O_EMPTY_PATH);
|
||||
ATF_REQUIRE(dfd >= 0);
|
||||
@ -256,7 +256,7 @@ ATF_TC_BODY(path_capsicum_empty, tc)
|
||||
ATF_REQUIRE(fd >= 0);
|
||||
CHECKED_CLOSE(fd);
|
||||
|
||||
cap_rights_init(&rights, CAP_READ | CAP_LOOKUP | CAP_WRITE);
|
||||
cap_rights_init(&rights, CAP_READ, CAP_LOOKUP, CAP_WRITE);
|
||||
ATF_REQUIRE(cap_rights_limit(pathfd, &rights) == 0);
|
||||
fd = openat(pathfd, "", O_RDWR | O_EMPTY_PATH | O_APPEND);
|
||||
ATF_REQUIRE(fd >= 0);
|
||||
@ -265,7 +265,7 @@ ATF_TC_BODY(path_capsicum_empty, tc)
|
||||
/*
|
||||
* CAP_SEEK is needed to open a file for writing without O_APPEND.
|
||||
*/
|
||||
cap_rights_init(&rights, CAP_READ | CAP_LOOKUP | CAP_WRITE);
|
||||
cap_rights_init(&rights, CAP_READ, CAP_LOOKUP, CAP_WRITE);
|
||||
ATF_REQUIRE(cap_rights_limit(pathfd, &rights) == 0);
|
||||
fd = openat(pathfd, "", O_RDWR | O_EMPTY_PATH);
|
||||
ATF_REQUIRE_ERRNO(ENOTCAPABLE, fd == -1);
|
||||
|
Loading…
Reference in New Issue
Block a user