mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-11 14:10:34 +00:00
Code Issues Releases Activity

Disable the kernacc() check in mtx_validate() until such time that kernacc

Browse Source 
does not require Giant.

This means that we may miss panics on a class of mutex programming bugs,
but only if running with a Chernobyl setting of debug-flags.

Spotted by:	Pete Carah <pete@ns.altadena.net>
This commit is contained in:
Poul-Henning Kamp 2002-10-25 08:40:20 +00:00
parent 15cd62721a
commit fa669ab7b8
Notes: svn2git 2020-12-20 02:59:44 +00:00 
svn path=/head/; revision=105919
2 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
sys/kern/kern_mutex.c
View File

@ -858,6 +858,10 @@ void
mtx_validate(struct mtx *m)
{
/*
* XXX: When kernacc() does not require Giant we can reenable this check
*/
#ifdef notyet
/*
* XXX - When kernacc() is fixed on the alpha to handle K0_SEG memory properly
* we can re-enable the kernacc() checks.
@ -873,6 +877,7 @@ mtx_validate(struct mtx *m)
VM_PROT_READ | VM_PROT_WRITE))
panic("Can't read and write to mutex %p", m);
#endif
#endif
}
#endif

5
sys/kern/subr_turnstile.c
View File

@ -858,6 +858,10 @@ void
mtx_validate(struct mtx *m)
{
/*
* XXX: When kernacc() does not require Giant we can reenable this check
*/
#ifdef notyet
/*
* XXX - When kernacc() is fixed on the alpha to handle K0_SEG memory properly
* we can re-enable the kernacc() checks.
@ -873,6 +877,7 @@ mtx_validate(struct mtx *m)
VM_PROT_READ | VM_PROT_WRITE))
panic("Can't read and write to mutex %p", m);
#endif
#endif
}
#endif