This bug showed up when you had more than 3 devices displayed. (thus
requiring a second line of display)
Here's a quote From the PR:
When wrefresh() is called with a subwindow as argument, __set_subwin
might be called with reversed arguments if wrefresh() decides to calls
quickch(). This may cause use of negative array indexes, with a
resulting segfault.
Since quickch() manipulates the line structures belonging to curscr,
it looks like all subwindows of curscr should be updated.
PR: bin/8086
Submitted by: Tor Egge <Tor.Egge@fast.no>
This will make a number of things easier in the future, as well as (finally!)
avoiding the Id-smashing problem which has plagued developers for so long.
Boy, I'm glad we're not using sup anymore. This update would have been
insane otherwise.
specified in the top level Makefiles.
Previously I missed dozens of Makefiles that skip the install after
using `cmp -s' to decide that the install isn't necessary.
as tn3270 can replace _putchar(0 with their own routine and still keep
using the __cputchar() routine used by all of the other curses routines.
Reviewed by: "Andrey A. Chernov, Black Mage" <ache@astral.msk.su>
and don't return error, if non-terminals. This fix allows curses
to work into full duplex pipes under control of main program,
like good old curses does.
o __FULLINE added for AL/DL/CS optimization with __noqch.
refresh.c
o Attributes does not turned off before clearing screen, cause
highlighted screen.
o Proper usage of 'affcnt' tputs parameter, affects terminals with
padding.
o make AL/DL/CS optimize not only for __FULLWIN but for __FULLLINE.
ATTENTION: original code works _only_for_ FULLWIN, i.e. if you
use two FULLLINE windows like in 'talk', you have full slow repaint with
original code, I enhance this thing. All other fixes marked
with phrase 'wrong for non-full windows' or WFNFW is continue of this fix.
I rewrite scroll code too for proper working (see below and tty.c
changes).
o DEBUG code always use 'i' index from 0 to curscr->maxy instead of
'i - win->begy', fixed
o check added into DEBUG to be shure that index inside current window.
o ->hash assigment code is WFNFW (forget win->begy).
o when CE usage required, and last spaces number counted, code don't check
attributes, so last standouted space will be incorrectly cleared.
o cep (start pointer) forget to add win->begy/win->begx, code WFNFW.
o clsp (last space) wrong in two places at once: forget to add win->begy
(WFNFW) and incorrectly use 'win->begx * __LDATASIZE' in pointer
arithmetics.
o clsp check incorrect: was 'clsp < win->maxx * __LDATASIZE', need to
be 'clsp < win->maxx
o Attributes does not turned off before clearing end of line, cause
highlighted end of line.
o When find how many lines from the top/bottom of the screen are unchanged,
code always forget '- win->begy', WFNFW.
o NO_JERKINESS code forgets to add win->begy, WFNFW.
o Curw & Curs changed in comment description
o In search for the largest block of text not changed forget to add
'- win->begy' (several places), WFNFW.
o Forget to add '- win->begy' for non-dirty lines, WFNFW.
o touchline forget to add '- win->begy', WFNFW.
o rewrite scrolln():
* remove win parameter, we deal with whole screen (curscr) now;
* use NL or '\n' instead of sf, it is faster in any case;
(imagine: cat written on curses now use '\n' for scroll
like standard cat, no ugly escapes)
* use dl (if present) instead of DL, if abs(n) == 1, the same
about al/sr, it is faster;
* change win->maxy to 'curscr->maxy - 1', we deal with whole screen
here, WFNFW.
* SF can be correctly issued only if cursor at bottom of scroll
region (whole screen region included too), fix this;
* sr/SR can be correctly issued only if cursor at top of scroll
region (whole screen region included too), fix this;
* use pre-calculaded (in setterm.c) __usecs variable to determine
usage of CS or AL/DL;
* completely rewrite scroll region stuff using __set_scroll_region
from tty.c (see below);
tty.c
o Added __set_scroll_region function which set CS region and stays
back in old position. Use SC/RC (save/restore cursor) if possible,
else use HO and __mvcur.
o __startwin: added __set_scroll_region(whole screen) at program
startup, if __usecs;
o endwin: added __set_scroll_region(whole screen) at program
exit, if __usecs;
o Fix all tc{set/get}attrs to works properly, when stdin redirected,
use /dev/tty in this case (needed for some applications).
setterm.c
o Add new variable __usecs, if (!AL/al || !Dl/dl) && CS && (SC && RC || HO)
(save/restore cursor used in __set_scroll_region in tty.c).
o Set __noqch, if !__usecs && (!AL/al || !DL/dl).
o Proper ospeed initialization for tputs, i.e. if speed == B9600,
ospeed = 13
curses.c
o Add __usecs variable that indicates usage of CS (if AL/DL absent).
curses.h
o Allow translation with applications which includes <sgtty.h>,
undef BXXX manually to avoid redefinition and include termios
to define proper ones.
o Define old-style names curx/begx/maxx/etc. for old applications.
Define _tty like __baset too.
o Typedef SGTTY type for old applications (SGTTY == struct termios).
o wstandout/wstandend should be int and not char*, some old
applications relay on this fact. See standout.c too.
o __FULLINE added indicated line width == terminal width, needed
for refresh using AL/DL/CS with __noqch, see refresh.c changes.
o Add extern __usecs variable that indicates usage of CS (if AL/DL absent).
o Add __set_scroll_region() prototype, see tty.c and refresh.c changes
for details.
o Change winch() character mask from 0177 to 0377, we don't need to
strip high bit on national characters.
o Allow translate on systems with _BSD_VA_LIST_ undefined, such as
FreeBSD 1.1.5.1
o __tty_fileno added to allows work with stdin redirected, see tty.c
o Privately declare tputs (..., void) and externally tputs(..., int),
many applications require this. Maybe not nice thing, but needed.
o Remove _putchar definition and replace it to proper _putchar
prototype, some old apps declares: 'extern int _putchar()'
and don't even include curses.h in such modules. See putchar.c
cr_put.c
o __mvcur: if destline == destcol && outline == outcol do nothing,
i.e. don't issue any escapes.
o Proper usage of 'affcnt' tputs parameter, affects terminals with
padding.
cur_hash.c
o Change char->unsigned char for proper sum 8-bit national characters.
getch.c
o check for inp == EOF added, don't add EOF to window.
getstr.c
o check for EOF added, don't add EOF to str.
insertln.c
o add cast to (int) in comparation of y and win->cury, this produce
big number (cast to (unsigned)) if y < 0
tstp.c
o Fix all tc{set/get}attrs to works properly, when stdin redirected,
use /dev/tty in this case (needed for some applications).
o add tstp() function for compatibility, some applications wants it.
standout.c
o Some old applications relay in fact that wstandout/wstandend
returns int instead of char*, change return type to OK/ERR.
putchar.c
o Add _putchar function (which calls __cputchar),
some old apps declares: 'extern int _putchar()'
and don't even include curses.h in such modules.
distributed in keith bostic's nvi (got his permission first). Most changes
are cosmetic, but a few errors (mostly in tty..c) were cleared up.
Reviewed by: Sean Eric Fagan
