included twice by lprint.c, which included both finger.h and extern.h.
finger.h, in turn, includes extern.h. The redundant include of extern.h
was removed from lprint.c, as part of this change, but the include guards
were added anyway out of spite.
print a warning, and set the idletime variable for the entry to -1;
then pick up the -1 later in sprint() and lprint() and ignore those
idle times by printing just whitespace. When third party applications,
such as kdm, insert utmp entries, they sometimes use strings like ":0",
which can't be stat()'d and currently result in warnings that are
not helpful to the user.
Add some constness to avoid some warnings.
Remove use register keyword.
Deal with missing/unneeded extern/prototypes.
Some minor type changes/casts to avoid warnings.
Reviewed by: md5
cc1: warnings being treated as errors
usr.bin/finger/lprint.c: In function `lprint':
usr.bin/finger/lprint.c:191: warning: precision is not type int (arg 2)
*** Error code 1
Pointy hat to: markm
of the recent WARNS commits. The idea is:
1) FreeBSD id tags should follow vendor tags.
2) Vendor tags should not be compiled (though copyrights probably should).
3) There should be no blank line between including cdefs and __FBSDIF.
By default, behave like the old ugly 4.4bsd finger and print office
information instead of remote login information.
It's an easy one line fix to make it behave like most other vendor's
fingers if we decide to change the default.
Reviewed by: pst
