1
0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-13 10:02:38 +00:00
Mirror of the FreeBSD src repository https://git.FreeBSD.org/src.git .
Go to file
Greg Foster 00a80538b4 lacp: short timeout erroneously declares link-flapping
Panasas was seeing a higher-than-expected number of link-flap events.
After joint debugging with the switch vendor, we determined there were
problems on both sides; either of which might cause the occasional
event, but together caused lots of them.

On the switch side, an internal queuing issue was causing LACP PDUs --
which should be sent every second, in short-timeout mode -- to sometimes
be sent slightly later than they should have been. In some cases, two
successive PDUs were late, but we never saw three late PDUs in a row.

On the FreeBSD side, we saw a link-flap event every time there were two
late PDUs, while the spec says that it takes *three* seconds of downtime
to trigger that event. It turns out that if a PDU was received shortly
before the timer code was run, it would decrement less than a full
second after the PDU arrived. Then two delayed PDUs would cause two
additional decrements, causing it to reach zero less than three seconds
after the most-recent on-time PDU.

The solution is to note the time a PDU arrives, and only decrement if at
least a full second has elapsed since then.

Reported by:	Greg Foster <gfoster@panasas.com>
Reviewed by:	gallatin
Tested by:	Greg Foster <gfoster@panasas.com>
MFC after:	3 days
Sponsored by:	Panasas
Differential Revision:	https://reviews.freebsd.org/D35070
2022-04-27 12:41:30 -07:00
.cirrus-ci Cirrus-CI: add some timing info on pkg install failure 2021-08-04 15:02:00 -04:00
.github GitHub: Add libefivar's path to CODEOWNERS 2022-02-27 09:11:39 -07:00
bin pax(1): Remove a few double words in source code comments 2022-04-09 14:27:39 +02:00
cddl ctf: Link CTF toolchain man pages to ctf.5 2022-04-21 11:20:28 -04:00
contrib libcxxrt: Insert padding in __cxa_dependent_exception 2022-04-27 09:41:26 -04:00
crypto ssh: use upstream SSH_OPENSSL_VERSION macro 2022-04-23 20:07:57 -04:00
etc bintrans: move files to a new directory 2022-04-18 10:53:11 +02:00
gnu libdialog: Bump shared library version to 10. 2021-10-27 09:30:24 -07:00
include Create a new GEOM utility, gunion(8). 2022-02-28 16:36:08 -08:00
kerberos5 pkgbase: Create a FreeBSD-kerberos package 2021-09-07 10:23:14 +02:00
lib Export _Unwind_Complete and _Unwind_VRS_Pop from arm's libgcc_s 2022-04-27 11:04:10 +02:00
libexec libexec/rc.d/hostapd: Down/up interface when interface is specified 2022-04-22 09:15:49 -07:00
release release: fix on-disc pkg binary symbolic links 2022-04-26 15:52:40 -04:00
rescue rescue: Link with -lncursesw instead of -lncursesw_real. 2022-02-11 13:58:59 -08:00
sbin setkey(8): Clarify language around AEAD ciphers. 2022-04-27 12:23:18 -07:00
secure ssh: update to OpenSSH v8.9p1 2022-04-13 16:00:56 -04:00
share rtsx: Number of tweaks for RTS5260. 2022-04-26 21:43:17 -04:00
stand stand: zfs: handle holes at the tail end correctly 2022-04-21 14:57:24 -05:00
sys lacp: short timeout erroneously declares link-flapping 2022-04-27 12:41:30 -07:00
targets bintrans: move files to a new directory 2022-04-18 10:53:11 +02:00
tests Fix build after 128b9bf9 2022-04-25 14:45:05 +03:00
tools stress2: Added a syzkaller reproducer 2022-04-22 06:20:14 +02:00
usr.bin base64: ignore -i as promised 2022-04-24 08:23:27 +02:00
usr.sbin rpc.tlsservd: Delete set but unused variable 2022-04-26 19:29:01 -07:00
.arcconfig Remove history.immutable from .arcconfig 2021-04-13 12:36:25 +01:00
.arclint
.cirrus.yml Cirrus-CI: add a manual amd64-gcc9 build and smoketest job 2022-02-15 12:55:14 -05:00
.clang-format clang-format: Add bitset loop macros 2021-09-21 12:08:01 -04:00
.gitattributes
.gitignore .gitignore: Restore inadvertently deleted file 2022-01-18 08:00:42 -08:00
COPYRIGHT Welcome 2022, update copyrights. 2022-01-01 09:49:49 -07:00
LOCKS
MAINTAINERS Remove myself from bhyve maintenance; ENOTIME. 2021-11-19 07:09:30 +10:00
Makefile cleankernel: A target to delete the kernel compile file 2022-02-11 12:51:24 -07:00
Makefile.inc1 bintrans: move files to a new directory 2022-04-18 10:53:11 +02:00
Makefile.libcompat Makefile.libcompat: Sort 2022-02-02 14:34:29 -07:00
Makefile.sys.inc
ObsoleteFiles.inc bintrans: move files to a new directory 2022-04-18 10:53:11 +02:00
README.md README.md: update gnu directory description 2021-12-17 08:45:31 -05:00
RELNOTES RELNOTES: Add an entry for boottrace(4) 2022-03-29 13:35:14 +02:00
UPDATING UPDATING: Fix a few typos 2022-04-10 10:11:17 +02:00

FreeBSD Source:

This is the top level of the FreeBSD source directory.

FreeBSD is an operating system used to power modern servers, desktops, and embedded platforms. A large community has continually developed it for more than thirty years. Its advanced networking, security, and storage features have made FreeBSD the platform of choice for many of the busiest web sites and most pervasive embedded networking and storage devices.

For copyright information, please see the file COPYRIGHT in this directory. Additional copyright information also exists for some sources in this tree - please see the specific source directories for more information.

The Makefile in this directory supports a number of targets for building components (or all) of the FreeBSD source tree. See build(7), config(8), FreeBSD handbook on building userland, and Handbook for kernels for more information, including setting make(1) variables.

Source Roadmap:

Directory Description
bin System/user commands.
cddl Various commands and libraries under the Common Development and Distribution License.
contrib Packages contributed by 3rd parties.
crypto Cryptography stuff (see crypto/README).
etc Template files for /etc.
gnu Commands and libraries under the GNU General Public License (GPL) or Lesser General Public License (LGPL). Please see gnu/COPYING and gnu/COPYING.LIB for more information.
include System include files.
kerberos5 Kerberos5 (Heimdal) package.
lib System libraries.
libexec System daemons.
release Release building Makefile & associated tools.
rescue Build system for statically linked /rescue utilities.
sbin System commands.
secure Cryptographic libraries and commands.
share Shared resources.
stand Boot loader sources.
sys Kernel sources.
sys/arch/conf Kernel configuration files. GENERIC is the configuration used in release builds. NOTES contains documentation of all possible entries.
tests Regression tests which can be run by Kyua. See tests/README for additional information.
tools Utilities for regression testing and miscellaneous tasks.
usr.bin User commands.
usr.sbin System administration commands.

For information on synchronizing your source tree with one or more of the FreeBSD Project's development branches, please see FreeBSD Handbook.