1
0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-23 11:18:54 +00:00
freebsd/etc/rc.d/savecore
Doug Barton 2822c33f8c This change does the following for the scripts that run up through
FILESYSTEMS (the default early_late_divider):
1. Move sysctl to run first
2. Move as many BEFOREs to REQUIREs as possible.
3. Minor effect, move hostid_save from right before mdconfig to right
   after.

A lot of the early scripts make use of sysctl one way or another so
running this first makes a lot of sense given that system-critical
values are often placed in sysctl.conf.

My original purpose for working on this was that while doing some
debugging on other stuff I noticed that the order of execution was
different in the first pass through the early scripts and the second.
In practice that doesn't matter because the scripts are not executed the
second time. However this _can_ result in problems if the difference in
the rcorder moves a script from the late section to the early section in
the second pass (which would mean the script would not get executed).
So, I wanted to make the order of execution of the scripts in the early
section more deterministic.

In the course of debugging the ordering problems I noticed that moving
the BEFOREs to REQUIREs prevented the changes in order from the first
pass to the second pass without having to make any substantial changes.
(Of course it's no secret that I think BEFORE should be avoided as much
as possible, but this is a good example of why.)

Reviewed by:	silence on freebsd-rc@
MFC after:	8.1-RELEASE
2010-05-19 19:03:19 +00:00

77 lines
1.2 KiB
Bash
Executable File

#!/bin/sh
#
# $FreeBSD$
#
# PROVIDE: savecore
# REQUIRE: dumpon ddb syslogd
# KEYWORD: nojail
. /etc/rc.subr
name="savecore"
start_cmd="savecore_start"
start_precmd="savecore_prestart"
stop_cmd=":"
savecore_prestart()
{
# Quit if we have no dump device
case ${dumpdev} in
[Nn][Oo] | '')
debug 'No dump device. Quitting.'
return 1
;;
[Aa][Uu][Tt][Oo])
dumpdev=`/bin/realpath /dev/dumpdev`
;;
esac
# If there is no crash directory set it now
case ${dumpdir} in
'')
dumpdir='/var/crash'
;;
[Nn][Oo])
dumpdir='NO'
;;
esac
if [ ! -c "${dumpdev}" ]; then
warn "Dump device does not exist. Savecore not run."
return 1
fi
if [ ! -d "${dumpdir}" ]; then
warn "Dump directory does not exist. Savecore not run."
return 1
fi
return 0
}
savecore_start()
{
local dev
case "${dumpdev}" in
[Aa][Uu][Tt][Oo])
dev=
;;
*)
dev="${dumpdev}"
;;
esac
if savecore -C "${dumpdir}" "${dev}" >/dev/null; then
savecore ${savecore_flags} ${dumpdir} ${dumpdev}
if checkyesno crashinfo_enable; then
${crashinfo_program} -d ${dumpdir}
fi
else
check_startmsgs && echo 'No core dumps found.'
fi
}
load_rc_config $name
run_rc_command "$1"