Mark Johnston 713264f6b8 netinet: Tighten checks for unspecified source addresses ... The assertions added in commit b0ccf53f24 ("inpcb: Assert against wildcard addrs in in_pcblookup_hash_locked()") revealed that protocol layers may pass the unspecified address to in_pcblookup(). Add some checks to filter out such packets before we attempt an inpcb lookup: - Disallow the use of an unspecified source address in in_pcbladdr() and in6_pcbladdr(). - Disallow IP packets with an unspecified destination address. - Disallow TCP packets with an unspecified source address, and add an assertion to verify the comment claiming that the case of an unspecified destination address is handled by the IP layer. Reported by: syzbot+9ca890fb84e984e82df2@syzkaller.appspotmail.com Reported by: syzbot+ae873c71d3c71d5f41cb@syzkaller.appspotmail.com Reported by: syzbot+e3e689aba1d442905067@syzkaller.appspotmail.com Reviewed by: glebius, melifaro MFC after: 2 weeks Sponsored by: Klara, Inc. Sponsored by: Modirum MDPay Differential Revision: https://reviews.freebsd.org/D38570		2023-03-06 15:06:00 -05:00
..
cc	Rack cannot be loaded without cc_newreno compiled into the kernel.	2022-12-14 15:37:48 -05:00
khelp	tcp: provide macros to access inpcb and socket from a tcpcb	2022-11-08 10:24:40 -08:00
libalias	libalias: improve handling of invalid SCTP packets	2022-11-15 21:05:02 +01:00
netdump	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
tcp_stacks	ktls: Accurately track if ifnet ktls is enabled	2023-02-09 12:44:44 -05:00
accf_data.c
accf_dns.c
accf_http.c
dccp.h
icmp6.h	pf: apply the network stack's ICMP rate limiting to ICMP errors sent by pf	2022-10-14 10:36:16 +02:00
icmp_var.h
if_ether.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
if_ether.h
igmp_var.h	igmp: use callout(9) directly instead of pr_slowtimo, pr_fasttimo	2022-08-17 11:50:31 -07:00
igmp.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
igmp.h
in_cksum.c	netinet: Implement in_cksum_skip() using m_apply()	2021-11-24 13:31:16 -05:00
in_debug.c	Use network epoch to protect local IPv4 addresses hash.	2021-10-22 14:40:53 -07:00
in_fib_algo.c
in_fib_dxr.c	fib_algo: shift / mask by constants in dxr_lookup()	2022-01-17 00:13:47 +01:00
in_fib.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
in_fib.h
in_gif.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
in_jail.c	sysent: Get rid of bogus sys/sysent.h include.	2022-05-28 20:52:17 +03:00
in_kdtrace.c	Fix dtrace SDT probe tcp:::debug-input	2021-12-20 17:15:43 -09:00
in_kdtrace.h	tcp: retire TCPDEBUG	2022-12-14 09:54:06 -08:00
in_mcast.c	in_mcat.c: change multicast not member condition	2023-03-03 22:25:17 -07:00
in_pcb_var.h	in_pcb: use jenkins hash over the entire IPv6 (or IPv4) address	2021-12-26 10:47:28 -08:00
in_pcb.c	netinet: Tighten checks for unspecified source addresses	2023-03-06 15:06:00 -05:00
in_pcb.h	netinet: Remove the IP(V6)_RSS_LISTEN_BUCKET socket option	2023-02-28 15:57:21 -05:00
in_prot.c
in_proto.c	netinet*: add back necessary headers	2022-10-26 08:16:44 -07:00
in_rmx.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
in_rss.c	in_rss: fix set but not used warning	2022-05-07 18:17:33 +02:00
in_rss.h
in_systm.h
in_var.h	inet: Simplify if_multiaddrs iteration.	2022-10-08 13:10:07 -04:00
in.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
in.h	netinet: Remove the IP(V6)_RSS_LISTEN_BUCKET socket option	2023-02-28 15:57:21 -05:00
ip6.h
ip_carp.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
ip_carp.h	protosw: separate pr_input and pr_ctlinput out of protosw	2022-08-17 11:50:31 -07:00
ip_divert.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
ip_divert.h	divert(4): provide statistics	2022-08-30 15:09:21 -07:00
ip_dummynet.h
ip_ecn.c
ip_ecn.h
ip_encap.c
ip_encap.h
ip_fastfwd.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
ip_fw.h	ipfw: add support radix tables and table lookup for MAC addresses	2022-06-04 19:12:29 +03:00
ip_gre.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
ip_icmp.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
ip_icmp.h	netinet*: remove PRC_ constants and streamline ICMP processing	2022-10-03 20:53:04 -07:00
ip_id.c
ip_input.c	netinet: Tighten checks for unspecified source addresses	2023-03-06 15:06:00 -05:00
ip_mroute.c	mroute: partially sanitize the file	2023-02-23 13:35:44 +00:00
ip_mroute.h	IPv4 multicast: fix netstat -g	2022-03-22 07:38:01 -05:00
ip_options.c
ip_options.h
ip_output.c	netinet: Remove the IP(V6)_RSS_LISTEN_BUCKET socket option	2023-02-28 15:57:21 -05:00
ip_reass.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
ip_var.h	ipfw: garbage collect ip_fw_chk_ptr	2023-03-03 10:30:15 -08:00
ip.h	ip_reass: retire ipreass_slowtimo() in favor of per-slot callout	2022-09-08 13:49:58 -07:00
pim_var.h
pim.h
raw_ip.c	ipfw: garbage collect ip_fw_chk_ptr	2023-03-03 10:30:15 -08:00
sctp_asconf.c	sctp: improve consistency	2022-05-14 06:28:19 +02:00
sctp_asconf.h
sctp_auth.c
sctp_auth.h
sctp_bsd_addr.c	sctp: Remove unused variable.	2022-04-12 14:58:59 -07:00
sctp_bsd_addr.h
sctp_cc_functions.c	sctp: plug set-but-not-used vars	2022-04-19 12:45:57 +00:00
sctp_constants.h	sctp: improve handling of sctp inpcb flags	2022-06-04 07:38:19 +02:00
sctp_crc32.c	sctp: fix a signed/unsigned mismatch.	2022-02-17 22:45:57 +01:00
sctp_crc32.h	sctp: fix a signed/unsigned mismatch.	2022-02-17 22:45:57 +01:00
sctp_header.h
sctp_indata.c	sctp: tweak panic message	2022-08-03 17:28:15 +02:00
sctp_indata.h
sctp_input.c	sctp: improve sending of ABORT packets in response to INIT-ACKs	2022-10-13 01:05:44 +02:00
sctp_input.h
sctp_kdtrace.c
sctp_kdtrace.h
sctp_lock_bsd.h	sctp: get rid of stcb send lock	2022-03-29 01:50:17 +02:00
sctp_module.c	protosw: refactor protosw and domain static declaration and load	2022-08-17 11:50:32 -07:00
sctp_os_bsd.h	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
sctp_os.h
sctp_output.c	sctp: improve handling of send() calls with no user data`	2022-08-08 12:53:42 +02:00
sctp_output.h	sctp: cleanup the SCTP_MAXSEG socket option.	2021-12-27 23:40:31 +01:00
sctp_pcb.c	sctp: minor changes due to upstreaming of Glebs recent changes	2022-11-06 23:06:40 +01:00
sctp_pcb.h	protosw: retire pr_drain and use EVENTHANDLER(9) directly	2022-08-17 11:50:31 -07:00
sctp_peeloff.c
sctp_peeloff.h
sctp_ss_functions.c	sctp: fix typos	2022-03-29 21:09:51 +02:00
sctp_structs.h	sctp: cleanup, no functional change	2022-06-08 22:35:14 +02:00
sctp_syscalls.c	sctp: ansify	2023-02-13 18:17:10 +00:00
sctp_sysctl.c	Adjust sctp_init_sysctls() definition to avoid clang 15 warning	2022-07-25 22:08:35 +02:00
sctp_sysctl.h	sctp: fix typos	2022-03-29 21:09:51 +02:00
sctp_timer.c	Fix unused variable warning in sctp_timer.c	2022-07-25 22:08:28 +02:00
sctp_timer.h
sctp_uio.h	sctp: get rid of stcb send lock	2022-03-29 01:50:17 +02:00
sctp_usrreq.c	sctp: minor changes due to upstreaming of Glebs recent changes	2022-11-06 23:06:40 +01:00
sctp_var.h	sctp: minor changes due to upstreaming of Glebs recent changes	2022-11-06 23:06:40 +01:00
sctp.h
sctputil.c	sctp: improve delivery of stream reset notifications	2023-02-02 14:46:10 +01:00
sctputil.h	sctp: more sb_cc related cleanups	2022-05-23 16:09:23 +02:00
siftr.c	pfil: add pfil_mem_{in,out}() and retire pfil_run_hooks()	2023-02-14 10:02:49 -08:00
tcp_accounting.h
tcp_ecn.c	tcp: retire TCPDEBUG	2022-12-14 09:54:06 -08:00
tcp_ecn.h	tcp: add conservative d.cep accounting algorithm	2022-11-06 12:05:22 +01:00
tcp_fastopen.c	tcp: provide macros to access inpcb and socket from a tcpcb	2022-11-08 10:24:40 -08:00
tcp_fastopen.h	Use stub inline functions for no-op versions of tcp_fastopen*().	2022-04-08 17:25:13 -07:00
tcp_fsm.h	tcp: remove a 4.4BSD relic	2022-12-13 20:21:45 -08:00
tcp_hostcache.c	tcp(4): Fix a typo in a sysctl description	2021-11-30 07:17:30 +01:00
tcp_hpts.c	tcp_hpts: Fix a typo in a source code comment	2023-01-11 11:33:29 +01:00
tcp_hpts.h	tcp_hpts: Correct some typos in source code comments	2022-09-04 12:47:49 +02:00
tcp_input.c	netinet: Tighten checks for unspecified source addresses	2023-03-06 15:06:00 -05:00
tcp_log_buf.c	BBLog: improve sysctl variables	2022-12-24 22:10:31 +01:00
tcp_log_buf.h	bblog: add logging of protocol user requests	2023-02-21 12:07:35 +01:00
tcp_lro.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
tcp_lro.h	tcp_lro: Fix for undefined behaviour.	2023-01-13 11:18:19 +01:00
tcp_offload.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
tcp_offload.h
tcp_output.c	Change hw_tls to a bool	2023-02-25 09:59:11 -07:00
tcp_pcap.c	tcp: embed inpcb into tcpcb	2022-12-07 09:00:48 -08:00
tcp_pcap.h
tcp_ratelimit.c	ktls: Accurately track if ifnet ktls is enabled	2023-02-09 12:44:44 -05:00
tcp_ratelimit.h	rack and bbr not loading if TCP_RATELIMIT is not configured.	2023-01-05 11:59:52 -05:00
tcp_reass.c	tcp: retire TCPDEBUG	2022-12-14 09:54:06 -08:00
tcp_sack.c	tcp: retire TCPDEBUG	2022-12-14 09:54:06 -08:00
tcp_seq.h	tcp: Correctly compute the retransmit length for all 64-bit platforms.	2022-06-03 10:49:17 +02:00
tcp_stats.c	tcp: add missing void keyword to tcp_stats_init	2023-02-13 18:38:04 +00:00
tcp_subr.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
tcp_syncache.c	tcp: Remove a couple of always-false checks from syncache_socket()	2023-02-07 15:22:54 -05:00
tcp_syncache.h	tcp: Add/update AccECN related statistics and numbers	2022-02-10 00:21:31 +01:00
tcp_timer.c	bblog: improve timeout event handling	2023-02-21 22:46:15 +01:00
tcp_timer.h	tcp: rearrange enum and remove unused variable	2023-02-21 18:26:49 +01:00
tcp_timewait.c	tcp: retire TCPDEBUG	2022-12-14 09:54:06 -08:00
tcp_usrreq.c	tcp: Make TCP PCAP buffer properly configurable.	2023-02-28 20:12:11 +01:00
tcp_var.h	Change hw_tls to a bool	2023-02-25 09:59:11 -07:00
tcp.h	ipfw: Have NAT steal the TH_RES1 bit, instead of the TH_AE bit	2022-11-09 11:19:19 +01:00
tcpip.h
toecore.c	IfAPI: Explicitly include <net/if_private.h> in netstack	2023-01-31 15:02:16 -05:00
toecore.h
udp_usrreq.c	inpcb: use family specific sockaddr argument for bind functions	2023-02-15 10:30:16 -08:00
udp_var.h	udp: add protocol method declarations to udp_var.h	2022-12-07 11:51:49 -08:00
udp.h	headers: make a few more headers self-contained	2022-01-03 10:12:30 +01:00
udplite.h