mirror of
https://git.FreeBSD.org/src.git
synced 2025-01-18 15:30:21 +00:00
12752a4a78
[FastIsel][X86] Fix invalid register replacement for bool args Summary: Consider the following IR: %3 = load i8* undef %4 = trunc i8 %3 to i1 %5 = call %jl_value_t.0* @foo(..., i1 %4, ...) ret %jl_value_t.0* %5 Bools (that are the result of direct truncs) are lowered as whatever the argument to the trunc was and a "and 1", causing the part of the MBB responsible for this argument to look something like this: %vreg8<def,tied1> = AND8ri %vreg7<kill,tied0>, 1, %EFLAGS<imp-def>; GR8:%vreg8,%vreg7 Later, when the load is lowered, it will insert %vreg15<def> = MOV8rm %vreg14, 1, %noreg, 0, %noreg; mem:LD1[undef] GR8:%vreg15 GR64:%vreg14 but remember to (at the end of isel) replace vreg7 by vreg15. Now for the bug. In fast isel lowering, we mistakenly mark vreg8 as the result of the load instead of the trunc. This adds a fixup to have vreg8 replaced by whatever the result of the load is as well, so we end up with %vreg15<def,tied1> = AND8ri %vreg15<kill,tied0>, 1, %EFLAGS<imp-def>; GR8:%vreg15 which is an SSA violation and causes problems later down the road. This fixes PR21557. Test Plan: Test test case from PR21557 is added to the test suite. Reviewers: ributzka Reviewed By: ributzka Subscribers: llvm-commits Differential Revision: http://reviews.llvm.org/D6245 This fixes a possible assertion failure when compiling toolbox.cxx from LibreOffice 4.3.5. Reported by: kwm |
||
|---|---|---|
| .. | ||
| amd | ||
| apr | ||
| apr-util | ||
| atf | ||
| binutils | ||
| bmake | ||
| bsnmp | ||
| byacc | ||
| bzip2 | ||
| com_err | ||
| compiler-rt | ||
| dialog | ||
| diff | ||
| dma | ||
| dtc | ||
| ee | ||
| elftoolchain | ||
| expat | ||
| file | ||
| flex | ||
| gcc | ||
| gcclibs | ||
| gdb | ||
| gdtoa | ||
| gperf | ||
| groff | ||
| hyperv/tools | ||
| ipfilter | ||
| jemalloc | ||
| ldns | ||
| ldns-host | ||
| less | ||
| libarchive | ||
| libbegemot | ||
| libc-pwcache | ||
| libc-vis | ||
| libc++ | ||
| libcxxrt | ||
| libexecinfo | ||
| libgnuregex | ||
| libpcap | ||
| libreadline | ||
| libstdc++ | ||
| libucl | ||
| libxo | ||
| llvm | ||
| mdocml | ||
| mknod | ||
| mtree | ||
| ncurses | ||
| netbsd-tests | ||
| netcat | ||
| ngatm | ||
| ntp | ||
| nvi | ||
| ofed | ||
| one-true-awk | ||
| openbsm | ||
| openpam | ||
| openresolv | ||
| opie | ||
| pam_modules/pam_passwdqc | ||
| pf | ||
| pjdfstest | ||
| pnpinfo | ||
| sendmail | ||
| serf | ||
| smbfs | ||
| sqlite3 | ||
| subversion | ||
| tcp_wrappers | ||
| tcpdump | ||
| tcsh | ||
| telnet | ||
| tnftp | ||
| top | ||
| traceroute | ||
| tzcode | ||
| tzdata | ||
| unbound | ||
| unvis | ||
| vis | ||
| wpa | ||
| xz | ||