mirror/freebsd
1
0
Fork 0
mirror of https://git.FreeBSD.org/src.git synced 2025-01-30 16:51:41 +00:00
Code Issues Releases Activity
1f641a35fd
freebsd/usr.sbin
History
David Bright 1f641a35fd Fix several Coverity-detected issues in newsyslog. 
- CID 1394815, CID 1305673: Dereference before null check - memory was
  allocated and the allocation checked for NULL with a call to errx()
  if it failed. Code below that was guaranteed that the pointer was
  non-NULL, but there was another check for NULL at the exit of the
  function (after the memory had already been referenced). Eliminate
  the useless NULL check.

- CID 1007452: Resource leak - Storage intended to be allocated and
  returned to the caller was never freed. This was the result of a
  regression in the function signature introduced in r208648 (2010)
  (thanks for that find, @cem!). Fixed by altering the function
  signature and passing the allocated memory to the caller as
  intended. This also fixes PR158794.

- CID 1008620: Logically dead code in newsyslog.c - This was a direct
  result of CID 1007452. Since the memory allocated as described there
  was not returned to the caller, a subsequent check for the memory
  having been allocated was dead code. Returning the memory
  re-animates the code that is the subject of this CID.

- CID 1006131: Unused value - in parsing a configuration file, a
  pointer to the end of the last field was saved, but not used after
  that. Rewrite to use the pointer value. This could have been fixed
  by avoiding the assignment altogether, but this solutions more
  closely follows the pattern used in the preceding code.

PR:		158794
Reported by:	Coverity, Ken-ichi EZURA <k.ezura@gmail.com> (PR158794)
Reviewed by:	cem, markj
MFC after:	1 week
Differential Revision:	https://reviews.freebsd.org/D19105
2019-02-22 15:31:50 +00:00
..
ac
accton
acpi Fix 32-bit buildworld broken by r343438. 2019-01-25 20:53:29 +00:00
adduser
amd Move amd.map to usr.sbin/amd/amd/ 2018-09-18 00:32:10 +00:00
ancontrol
apm
apmd Move apmd.conf to CONFS in usr.sbin/apmd which simplifies this nicely. 2018-07-26 16:51:23 +00:00
arp Remove infrastructure for token-ring networks. 2018-03-28 23:33:26 +00:00
audit
auditd Move OpenBSM to CONFS 2018-08-11 13:23:09 +00:00
auditdistd
auditreduce
authpf
autofs There is no way of escaping literal $ signs in auto_master(5), which 2018-12-28 15:11:22 +00:00
bhyve Catch up with ACPICA 20190215. 2019-02-21 21:15:49 +00:00
bhyvectl style(9) remove unnecessary blank tabs. 2018-06-13 03:35:24 +00:00
bhyveload userboot: handle guest interpreter mismatches more intelligently 2018-09-01 02:23:45 +00:00
binmiscctl Improve the binmiscctl manual page 2018-07-20 22:50:21 +00:00
blacklistctl
blacklistd Move blacklistd.conf to usr.sbin/blacklistd/ 2018-07-31 16:39:38 +00:00
bluetooth Improve Bluetooth device discovery support for Android and Microsoft devices. 2019-02-08 13:10:45 +00:00
boot0cfg Add a “skip_dsn” option to g_part's bootcode verb to prevent g_part_mbr 2018-11-27 14:58:19 +00:00
bootparamd
bsdconfig Remove iBCS2, part1: userspace 2018-12-19 21:56:54 +00:00
bsdinstall powerpc/boot: Move ubldr to /boot/uboot, and make this a separate filesystem 2019-02-18 01:57:47 +00:00
bsnmpd snmp_hostres(3): fix a typo in sanity checks in handle_chunk() 2019-02-18 03:23:10 +00:00
btxld
camdd Make timespecadd(3) and friends public 2018-07-30 15:46:40 +00:00
cdcontrol
chkgrp
chown Handle overflow of uid or gid in arguments for chown 2018-09-26 18:40:57 +00:00
chroot
ckdist
clear_locks
config config(8): Remove all instances of an option when opting out 2018-12-22 06:08:06 +00:00
cpucontrol cpucontrol: check for the supposed firmware file type and skip 2019-01-11 08:35:49 +00:00
crashinfo Support compressed crash dumps in crashinfo(8). 2018-07-23 18:08:56 +00:00
cron Move etc/crontab to usr.sbin/cron/cron/ 2018-09-06 14:55:54 +00:00
crunch send-pr: wave goodbye 2018-08-19 07:12:35 +00:00
ctladm Fix passing wrong variables to nvlist_destroy() after r333446. 2018-12-21 17:22:15 +00:00
ctld iscsi: simplify the capsicumization 2018-11-30 19:40:16 +00:00
cxgbetool cxgbetool(8): Add a subaction (tcbrss <n>) that can be used with "pass" 2018-10-27 05:26:09 +00:00
daemon Cross-reference nohup(1) and daemon(8). 2018-11-09 13:47:06 +00:00
dconschat
devctl Create devctl freeze/thaw. 2018-08-23 05:05:47 +00:00
devinfo devinfo_init() returns an errno, but doesn't set errno, so the error 2018-05-30 15:08:59 +00:00
diskinfo
dumpcis Remove All Rights Reserved 2019-02-05 21:37:34 +00:00
editmap
edquota
eeprom
efibootmgr Regularize the Netflix copyright 2019-02-04 21:28:25 +00:00
efidp Regularize the Netflix copyright 2019-02-04 21:28:25 +00:00
efivar Add the unix path to the output of efivar --load-option 2019-02-20 05:19:16 +00:00
etcupdate Cross-reference mergemaster(8) & etcupdate(8). 2018-11-27 10:31:29 +00:00
extattr
extattrctl
fdcontrol
fdformat
fdread
fdwrite
fifolog
flowctl
fmtree
freebsd-update freebsd-update: Clarify help text 2019-02-19 17:38:24 +00:00
fstyp Normally when an attempt is made to mount a UFS/FFS filesystem whose 2018-12-06 00:09:39 +00:00
ftp-proxy
fwcontrol
getfmac
getpmac
gpioctl gpioctl.8: Fix man page section 2018-06-06 18:52:33 +00:00
gssd * Handle SIGPIPE in gssd 2019-02-21 01:30:37 +00:00
gstat - Add CSV output to gstat via -C flag. 2018-08-21 11:22:49 +00:00
hyperv
i2c
ifmcstat
inetd Move inetd.conf to usr.sbin/inetd/ 2018-08-12 13:29:40 +00:00
iostat iostat: update man page for r277566 2018-08-20 13:42:22 +00:00
iovctl
ip6addrctl
ipfwpcap Buildfix for GCC after r334277. 2018-05-28 09:41:44 +00:00
iscsid iscsi: simplify the capsicumization 2018-11-30 19:40:16 +00:00
jail Clarify error messages a bit. 2019-01-18 23:00:52 +00:00
jexec
jls
kbdcontrol Silence Clang Scan warning about use of unitialized variable. 2019-01-23 10:05:27 +00:00
kbdmap Silence a CI warning regarding the use of strcpy(). 2019-01-22 13:11:15 +00:00
keyserv
kgmon
kgzip
kldxref kldxref: use appropriate Elf_Off type for offsets 2018-11-09 15:02:53 +00:00
lastlogin A single comma was missing to separate the "see also" items in 2018-10-20 17:22:04 +00:00
lpr Move hosts.lpd and printcap to usr.sbin/lpr/lpd/ 2018-09-20 09:21:05 +00:00
lptcontrol
mailstats
mailwrapper
makefs makefs: use FreeBSD brelse function signature 2018-07-26 13:33:10 +00:00
makemap
manctl
memcontrol
mergemaster Cross-reference mergemaster(8) & etcupdate(8). 2018-11-27 10:31:29 +00:00
mfiutil Make mfiutil show progress print out the elapsed time estimate in a 2018-10-13 02:21:23 +00:00
mixer
mld6query Fix mld6query(8) and add a new -g option 2018-05-11 19:37:18 +00:00
mlx5tool Check that the address is specified in mlx5tool(8). 2018-03-08 15:28:13 +00:00
mlxcontrol
mount_smbfs
mountd Bump .Dd for today's edit. 2019-02-11 16:31:15 +00:00
moused Remove mse(4) from tree 2018-10-22 02:34:10 +00:00
mpsutil Regularize the Netflix copyright 2019-02-04 21:28:25 +00:00
mptable
mptutil Delete copypasta 2018-02-23 17:20:53 +00:00
mtest mtest: build with WARNS=3 2018-05-19 20:57:22 +00:00
nandsim
nandtool
ndiscvt ndiscvt(8): abort if no IDs were found during conversion. 2019-01-30 12:32:47 +00:00
ndp Update the "flag" for draft-ietf-6man-ipv6only-flag. 2018-11-03 18:03:24 +00:00
newsyslog Fix several Coverity-detected issues in newsyslog. 2019-02-22 15:31:50 +00:00
nfscbd
nfsd Fix the usage error I introduced in r344192. 2019-02-21 22:49:39 +00:00
nfsdumpstate
nfsrevoke
nfsuserd Add missing endpwent() and endgrent() calls to nfsuserd(8). 2018-08-28 15:18:14 +00:00
ngctl Add blank line after each item in "ngctl ls -l" 2018-10-26 19:16:17 +00:00
nghook
nmtree
nologin
nscd Workaround for nscd(8) failure with large entries. 2019-01-17 20:01:06 +00:00
ntp Fix typo introduced in r340439 - s/ETN/ETC/ 2018-11-14 18:38:27 +00:00
nvram
ofwdump
pc-sysinstall
pciconf Require write access when mmapping BAR. 2018-08-03 18:35:20 +00:00
periodic periodic/weekly/340.noid: do not use sysrc(8) that depends 2018-12-15 23:20:08 +00:00
pkg Move pkg/FreeBSD.conf to usr.sbin/pkg/ 2018-07-31 16:42:03 +00:00
pmc Fix build with GCC 8.1. 2018-10-01 16:16:05 +00:00
pmcannotate Teach pmcannotate about $TMPDIR and _PATH_TMP 2018-05-18 14:14:04 +00:00
pmccontrol restore pmccontrol -L behavior on x86 2018-09-24 19:06:09 +00:00
pmcstat Regularize the Netflix copyright 2019-02-04 21:28:25 +00:00
pmcstudy Regularize the Netflix copyright 2019-02-04 21:28:25 +00:00
pnfsdscopymr Fix the err() arguments for a nfssvc(8) failure. 2018-08-08 20:30:12 +00:00
pnfsdsfile Document the new "-m" command line option for pnfsdsfile(8). 2018-07-01 17:51:52 +00:00
pnfsdskill Document the "-f" option added to pnfsdskill(8) by r336176. 2018-07-10 18:44:44 +00:00
pnpinfo
portsnap Now that the portsnap buildbox is generating the raw bits for INDEX-13, 2018-10-25 08:05:53 +00:00
powerd powerd(8): allow to force a method of battery state query 2019-01-06 02:39:03 +00:00
ppp Make ppp(8) buildable. 2018-09-19 07:09:55 +00:00
pppctl pppctl88) Avoid strcpy() copies on overlapping string. 2018-01-29 14:23:44 +00:00
praliases
praudit praudit(1): add tests 2018-06-17 17:31:16 +00:00
prometheus_sysctl_exporter
pstat
pw Add an example to pw.8 about how to add an existing user to a group. 2019-02-08 22:10:40 +00:00
pwd_mkdb pwd_mkdb: retire -B and -L endianness options 2018-10-21 00:48:38 +00:00
pwm pwm.8: fix markup in synopsis, add -f description 2019-02-06 04:00:37 +00:00
quot Normally when an attempt is made to mount a UFS/FFS filesystem whose 2018-12-06 00:09:39 +00:00
quotaon
rarpd
repquota
rip6query
rmt Fix missing files in METALOG with -DNO_ROOT 2018-06-29 21:15:17 +00:00
route6d Use the right variable when updating interface routes. 2018-08-08 20:15:40 +00:00
rpc.lockd
rpc.statd Reduce log spam from rpc.statd 2019-02-03 08:15:26 +00:00
rpc.umntall
rpc.yppasswdd
rpc.ypupdated Fix memory / resource leaks in usr.sbin/rpc.ypupdated/update.c 2019-02-18 03:15:25 +00:00
rpc.ypxfrd
rpcbind Plug a possible memory leak. 2018-03-19 05:49:26 +00:00
rrenumd
rtadvctl
rtadvd Update the "flag" for draft-ietf-6man-ipv6only-flag. 2018-11-03 18:03:24 +00:00
rtprio
rtsold Capsicumize rtsol(8) and rtsold(8). 2019-01-05 16:05:39 +00:00
rwhod capsicum: use a new capsicum helpers in tools 2018-11-04 19:24:49 +00:00
sa
sendmail
service Use "$@" instead of $* to cope with parameters that have spaces in 2018-06-13 06:11:04 +00:00
services_mkdb Add MPLS LSP-echo (RFC8029, March 2017) port. 2018-09-06 18:34:11 +00:00
sesutil Check element type before setting LEDs. 2019-02-04 01:24:10 +00:00
setfib
setfmac
setpmac
smbmsg
snapinfo
spi Add an example for displaying the manufacturer and size info from a 2018-06-23 23:08:25 +00:00
spkrtest
spray spray: fix the spelling in an output string 2018-03-05 16:13:29 +00:00
syslogd Remove trailing slash in pathname so that valid METALOG is created in the 2018-08-25 20:19:16 +00:00
sysrc sysrc(8): Send error message to stderr (not stdout) 2018-07-16 18:53:17 +00:00
tcpdchk
tcpdmatch
tcpdrop Use uintptr_t alone when assigning to kvaddr_t variables. 2018-07-10 13:03:06 +00:00
tcpdump
tests
traceroute
traceroute6 Fix in the documentation that the default hop limit is not 30, but 2018-05-02 19:36:46 +00:00
trim Re-add new small tool trim(8) to delete contents for blocks 2019-01-17 18:07:59 +00:00
trpt trpt(8): Clean up build hack to detect ancient compiler 2018-02-16 20:46:44 +00:00
tzsetup In read_zones(), check if the file name actually fit in the buffer 2018-08-09 02:47:22 +00:00
uathload
uefisign Fix alignment issue in uefisign 2018-12-19 22:47:37 +00:00
ugidfw
uhsoctl Use correct type for IOCTL request argument. 2018-11-02 22:23:25 +00:00
unbound Check that /etc/resolv.conf exists before trying to read it. 2018-11-27 09:46:01 +00:00
usbconfig Clean up the EXAMPLES section of usbconfig(8). This removes parts that 2018-04-29 10:45:09 +00:00
usbdump
utx
vidcontrol Oops, actually fix warnings from -Wpointer-sign. 2019-02-22 07:00:23 +00:00
vigr
vipw
wake
watch
watchdogd
wlandebug wlandebug: disable PIE to fix build failure 2019-02-16 12:49:55 +00:00
wpa Set default ciphers. 2018-12-12 05:18:53 +00:00
yp_mkdb
ypbind
ypldap
yppoll
yppush
ypserv su_data: correct macro expansion. 2018-02-08 14:53:34 +00:00
ypset
zic
zonectl
zzz
Makefile Re-add new small tool trim(8) to delete contents for blocks 2019-01-17 18:07:59 +00:00
Makefile.amd64 Remove obsolete asf(8) 2018-06-15 17:44:21 +00:00
Makefile.arm
Makefile.arm64
Makefile.i386 Remove obsolete asf(8) 2018-06-15 17:44:21 +00:00
Makefile.inc
Makefile.mips
Makefile.powerpc
Makefile.riscv Build ofwdump on riscv. 2018-07-24 20:20:17 +00:00
Makefile.sparc64