mirror of
https://git.FreeBSD.org/src.git
synced 2024-12-23 11:18:54 +00:00
8b7358ca43
validating the offset within a given memory buffer before handing the real work off to uiomove(9). Use uiomove_frombuf in procfs to correct several issues with integer arithmetic that could result in underflows/overflows. As a side-effect, the code is significantly simplified. Add additional sanity checks when computing a memory allocation size in pfs_read. Submitted by: rwatson (original uiomove_frombuf -- bugs are mine :-) Reported by: Joost Pol <joost@pine.nl> (integer underflows/overflows)
96 lines
3.1 KiB
C
96 lines
3.1 KiB
C
/*-
|
|
* Copyright (c) 1999 Brian Scott Dean, brdean@unx.sas.com.
|
|
* All rights reserved.
|
|
*
|
|
* This code is derived from software contributed to Berkeley by
|
|
* Jan-Simon Pendry under the following copyrights and conditions:
|
|
*
|
|
* Copyright (c) 1993 Jan-Simon Pendry
|
|
* Copyright (c) 1993
|
|
* The Regents of the University of California. All rights reserved.
|
|
*
|
|
* This code is derived from software contributed to Berkeley by
|
|
* Jan-Simon Pendry.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. All advertising materials mentioning features or use of this software
|
|
* must display the following acknowledgement:
|
|
* This product includes software developed by the University of
|
|
* California, Berkeley and its contributors.
|
|
* 4. Neither the name of the University nor the names of its contributors
|
|
* may be used to endorse or promote products derived from this software
|
|
* without specific prior written permission.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE REGENTS AND CONTRIBUTORS ``AS IS'' AND
|
|
* ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
|
|
* OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION)
|
|
* HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
|
|
* LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
|
|
* OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*
|
|
* From: @(#)procfs_regs.c 8.4 (Berkeley) 6/15/94
|
|
*
|
|
* From:
|
|
* $Id: procfs_regs.c,v 3.2 1993/12/15 09:40:17 jsp Exp $
|
|
* $FreeBSD$
|
|
*/
|
|
|
|
#include <sys/param.h>
|
|
#include <sys/systm.h>
|
|
#include <sys/lock.h>
|
|
#include <sys/mutex.h>
|
|
#include <sys/proc.h>
|
|
#include <sys/ptrace.h>
|
|
#include <sys/uio.h>
|
|
|
|
#include <machine/reg.h>
|
|
|
|
#include <fs/pseudofs/pseudofs.h>
|
|
#include <fs/procfs/procfs.h>
|
|
|
|
int
|
|
procfs_doprocdbregs(PFS_FILL_ARGS)
|
|
{
|
|
int error;
|
|
struct dbreg r;
|
|
|
|
PROC_LOCK(p);
|
|
if (p_candebug(td, p) != 0) {
|
|
PROC_UNLOCK(p);
|
|
return (EPERM);
|
|
}
|
|
|
|
_PHOLD(p);
|
|
/* XXXKSE: */
|
|
error = proc_read_dbregs(FIRST_THREAD_IN_PROC(p), &r);
|
|
if (error == 0) {
|
|
PROC_UNLOCK(p);
|
|
error = uiomove_frombuf(&r, sizeof(r), uio);
|
|
PROC_LOCK(p);
|
|
}
|
|
if (error == 0 && uio->uio_rw == UIO_WRITE) {
|
|
if (!P_SHOULDSTOP(p)) /* XXXKSE should be P_TRACED? */
|
|
error = EBUSY;
|
|
else
|
|
/* XXXKSE: */
|
|
error = proc_write_dbregs(FIRST_THREAD_IN_PROC(p), &r);
|
|
}
|
|
_PRELE(p);
|
|
PROC_UNLOCK(p);
|
|
|
|
uio->uio_offset = 0;
|
|
return (error);
|
|
}
|