mirror of
https://git.FreeBSD.org/src.git
synced 2024-12-20 11:11:24 +00:00
2cf5d587a9
that was introduced in revision 1.80. The problem manifested
itself with a `locking against myself' panic and could also
result in soft updates inconsistences associated with inodedeps.
The two problems are:
1) One of the background operations could manipulate the bitmap
while holding it locked with intent to create. This held lock
results in a `locking against myself' panic, when the background
processing that we have been coopted to do tries to lock the bitmap
which we are already holding locked. To understand how to fix this
problem, first, observe that we can do the background cleanups in
inodedep_lookup only when allocating inodedeps (DEPALLOC is set in
the call to inodedep_lookup). Second observe that calls to
inodedep_lookup with DEPALLOC set can only happen from the following
calls into the softdep code:
softdep_setup_inomapdep
softdep_setup_allocdirect
softdep_setup_remove
softdep_setup_freeblocks
softdep_setup_directory_change
softdep_setup_directory_add
softdep_change_linkcnt
Only the first two of these can come from ffs_alloc.c while holding
a bitmap locked. Thus, inodedep_lookup must not go off to do
request_cleanups when being called from these functions. This change
adds a flag, NODELAY, that can be passed to inodedep_lookup to let
it know that it should not do background processing in those cases.
2) The return value from request_cleanup when helping out with the
cleanup was 0 instead of 1. This meant that despite the fact that
we may have slept while doing the cleanups, the code did not recheck
for the appearance of an inodedep (e.g., goto top in inodedep_lookup).
This lead to the softdep inconsistency in which we ended up with
two inodedep's for the same inode.
Reviewed by: Peter Wemm <peter@yahoo-inc.com>,
Matt Dillon <dillon@earth.backplane.com>
|
||
|---|---|---|
| .. | ||
| alpha | ||
| amd64 | ||
| arm/include | ||
| boot | ||
| cam | ||
| coda | ||
| compat | ||
| compile | ||
| conf | ||
| contrib/dev | ||
| crypto | ||
| ddb | ||
| dev | ||
| fs | ||
| geom | ||
| gnu | ||
| i4b | ||
| i386 | ||
| ia64 | ||
| isa | ||
| isofs/cd9660 | ||
| kern | ||
| libkern | ||
| miscfs | ||
| modules | ||
| msdosfs | ||
| net | ||
| netatalk | ||
| netatm | ||
| netgraph | ||
| netinet | ||
| netinet6 | ||
| netipx | ||
| netkey | ||
| netnatm | ||
| netncp | ||
| netns | ||
| nfs | ||
| nfsclient | ||
| nfsserver | ||
| ntfs | ||
| nwfs | ||
| pc98 | ||
| pccard | ||
| pci | ||
| posix4 | ||
| powerpc | ||
| rpc | ||
| svr4 | ||
| sys | ||
| tools | ||
| ufs | ||
| vm | ||
| Makefile | ||