1
0
mirror of https://git.FreeBSD.org/src.git synced 2024-10-19 02:29:40 +00:00
freebsd/sys/cddl
Andriy Gapon f12a50fed2 Revert "dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag"
This reverts commit e92491d95f.
It was cherry-picked as f0ed49921c.

The general idea looked good to me.  In particular, it allowed to save
some memory and avoid memory allocation failures when a large buffer
size was requested along with ring and fill policies.

But I didn't take into account that the second, supposedly unused
buffer, was actually used as the scratch buffer.  The scratch buffer is
used as a temporary space for DTrace subroutines like copyin, copyinstr,
and alloca.

I think that the change can be fixed by allocating a separate smaller
buffer for the scratch buffer, but that fix would require more work than
I am able to do now.  Hence the revert.

Reported by:	Domagoj Stolfa
Diagnosed by:	Domagoj Stolfa, markj

(cherry picked from commit b9827c007a)
2024-04-21 15:28:59 +03:00
..
boot/zfs sys: Remove $FreeBSD$: one-line bare tag 2023-08-23 11:43:32 -06:00
compat/opensolaris sys: Remove $FreeBSD$: one-line catalog 2023-08-23 11:43:33 -06:00
contrib/opensolaris Revert "dtrace: make 'ring' and 'fill' policies imply 'noswitch' flag" 2024-04-21 15:28:59 +03:00
dev sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00