1
0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-12 09:58:36 +00:00
freebsd/contrib/libedit
Dimitry Andric c0f37bf652 Fix arm and aarch64 builds of libedit after r352275
On arm and arm64, where chars are unsigned by default, buildworld dies
with:

--- terminal.o ---
/usr/src/contrib/libedit/terminal.c:569:41: error: comparison of
integers of different signs: 'wint_t' (aka 'int') and 'wchar_t' (aka
'unsigned int') [-Werror,-Wsign-compare]
                                     el->el_cursor.v][where & 0370] !=
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/usr/src/contrib/libedit/terminal.c:659:28: error: comparison of
integers of different signs: 'wint_t' (aka 'int') and 'wchar_t' (aka
'unsigned int') [-Werror,-Wsign-compare]
                                     [el->el_cursor.h] == MB_FILL_CHAR)
                                     ~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~~~~~

Fix this by making MB_FILL_CHAR a wint_t, so no casting is needed.

Note that in https://reviews.freebsd.org/D21584 this was also proposed
by Yuichiro Naito <naito.yuichiro_gmail.com>.

Reviewed by:	bapt
Subscribers:	naito.yuichiro_gmail.com, ml_vishwin.info
MFC after:	3 weeks
X-MFC-With:	r352275
Differential Revision: https://reviews.freebsd.org/D21657
2019-09-14 21:49:42 +00:00
..
readline
TEST
chared.c
chared.h
chartype.c
chartype.h Fix arm and aarch64 builds of libedit after r352275 2019-09-14 21:49:42 +00:00
common.c
config.h
editline.3
editline.7
editrc.5
el.c
el.h
eln.c
emacs.c
filecomplete.c
filecomplete.h
hist.c
hist.h
histedit.h
history.c
historyn.c
keymacro.c
keymacro.h
literal.c
literal.h
Makefile
makelist
map.c
map.h
parse.c
parse.h
prompt.c
prompt.h
read.c
read.h
readline.c
refresh.c
refresh.h
search.c
search.h
shlib_version
sig.c
sig.h
sys.h
terminal.c Fix arm and aarch64 builds of libedit after r352275 2019-09-14 21:49:42 +00:00
terminal.h
tokenizer.c
tokenizern.c
tty.c
tty.h
vi.c