1
0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-19 10:53:58 +00:00
Mirror of the FreeBSD src repository https://git.FreeBSD.org/src.git .
Go to file
Adrian Chadd 59fbb5304d Fix a cleanup hang if cleanup gets called _during_ an active cleanup.
During power save testing I noticed that the cleanup code is being
called during a RUN->RUN state transition.  It's because the net80211
stack is treating that (for reasons I don't quitey know yet) as a
reassociation and this calls the node cleanup code.  The reason it's
seeing a RUN->RUN transition is because during active power save
stuff it's possible that the RUN->SLEEP and SLEEP->RUN transitions
happen so quickly that the deferred net80211 vap state code
"loses" a transition, namely the intermediary SLEEP transition.

So, this was causing the node reassociation code to sometimes be called
twice in quick succession and this would result in ath_tx_tid_cleanup()
to be called again.  The code calling it would always call pause, and
then only call resume if the TID didn't have "cleanup_inprogress" set.
Unfortunately it didn't check if it was already set on entry, so it
would pause but not call resume.  Thus, paused would be called more
than once (once before each entry into ath-tx_tid_cleanup()) but resume
would only be called once when the cleanup state was finished.

This doesn't entirely fix all of the issues seen in the cleanup path
but it's a necessary first step.

Since this is a stability fix, it should be merged to stable/10 at some
point.

Tested:

* AR5416, STA mode

MFC after:	7 days
2014-04-21 01:02:49 +00:00
bin Bump Dd, missed as part of r264098 and related commits. 2014-04-13 01:47:15 +00:00
cddl MFV r264666: 2014-04-18 21:15:12 +00:00
contrib NO_MAN= has been deprecated in favor of MAN= for some time, go ahead 2014-04-13 05:21:56 +00:00
crypto Apply upstream patch for EC calculation bug and bump version addendum. 2014-04-20 11:34:33 +00:00
etc when watchdogd is asked to exit nicely (via SIGTERM) it will 2014-04-16 22:26:42 +00:00
games NO_MAN= has been deprecated in favor of MAN= for some time, go ahead 2014-04-13 05:21:56 +00:00
gnu Add FreeBSD 10.1 to the list of recognized releases for Fx. 2014-04-13 11:57:51 +00:00
include langinfo.h: Hide YESSTR and NOSTR in strict POSIX mode. 2014-04-19 12:38:01 +00:00
kerberos5 NO_MAN= has been deprecated in favor of MAN= for some time, go ahead 2014-04-13 05:21:56 +00:00
lib Add the deprecated fp{get,set}* functions, a few ports use them. 2014-04-20 14:58:14 +00:00
libexec Fix releasing the lock in the parent atrun process after the queue 2014-04-17 16:00:26 +00:00
release Apply a slightly different color hammer to arm/release.sh: 2014-04-20 20:46:06 +00:00
rescue NO_MAN= has been deprecated in favor of MAN= for some time, go ahead 2014-04-13 05:21:56 +00:00
sbin When switching variables to flags in r243185 a few cases were missed. 2014-04-16 12:29:45 +00:00
secure NO_MAN= has been deprecated in favor of MAN= for some time, go ahead 2014-04-13 05:21:56 +00:00
share bsd-family-tree: Add NetBSD 6.1.4, 6.0.5 2014-04-20 03:27:38 +00:00
sys Fix a cleanup hang if cleanup gets called _during_ an active cleanup. 2014-04-21 01:02:49 +00:00
tests Fix variable type to avoid printf formatter warning. 2014-04-04 18:10:11 +00:00
tools Separate out enabling building clang and/or gcc for the system and 2014-04-18 17:03:58 +00:00
usr.bin login: Remove broken dialup log message. 2014-04-19 13:47:32 +00:00
usr.sbin Fix ACPI DSDT indentation cosmetic breakage introduced in r264631 -- 2014-04-18 16:01:19 +00:00
COPYRIGHT Bump copyright year. 2013-12-31 12:18:10 +00:00
LOCKS
MAINTAINERS This should have been obvious, but make it so. 2014-04-06 16:48:00 +00:00
Makefile Document the xdev* targets. 2014-04-14 16:15:11 +00:00
Makefile.inc1 Separate out enabling building clang and/or gcc for the system and 2014-04-18 17:03:58 +00:00
ObsoleteFiles.inc Add more obsolete files 2014-03-16 20:31:05 +00:00
README
UPDATING Document YES_HESIOD disappearing. 2014-04-18 17:06:18 +00:00

This is the top level of the FreeBSD source directory.  This file
was last revised on:
$FreeBSD$

For copyright information, please see the file COPYRIGHT in this
directory (additional copyright information also exists for some
sources in this tree - please see the specific source directories for
more information).

The Makefile in this directory supports a number of targets for
building components (or all) of the FreeBSD source tree, the most
commonly used one being ``world'', which rebuilds and installs
everything in the FreeBSD system from the source tree except the
kernel, the kernel-modules and the contents of /etc.  The ``world''
target should only be used in cases where the source tree has not
changed from the currently running version.  See:
http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/makeworld.html
for more information, including setting make(1) variables.

The ``buildkernel'' and ``installkernel'' targets build and install
the kernel and the modules (see below).  Please see the top of
the Makefile in this directory for more information on the
standard build targets and compile-time flags.

Building a kernel is a somewhat more involved process, documentation
for which can be found at:
   http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/kernelconfig.html
And in the config(8) man page.
Note: If you want to build and install the kernel with the
``buildkernel'' and ``installkernel'' targets, you might need to build
world before.  More information is available in the handbook.

The sample kernel configuration files reside in the sys/<arch>/conf
sub-directory (assuming that you've installed the kernel sources), the
file named GENERIC being the one used to build your initial installation
kernel.  The file NOTES contains entries and documentation for all possible
devices, not just those commonly used.  It is the successor of the ancient
LINT file, but in contrast to LINT, it is not buildable as a kernel but a
pure reference and documentation file.


Source Roadmap:
---------------
bin		System/user commands.

cddl		Various commands and libraries under the Common Development
		and Distribution License.

contrib		Packages contributed by 3rd parties.

crypto		Cryptography stuff (see crypto/README).

etc		Template files for /etc.

games		Amusements.

gnu		Various commands and libraries under the GNU Public License.
		Please see gnu/COPYING* for more information.

include		System include files.

kerberos5	Kerberos5 (Heimdal) package.

lib		System libraries.

libexec		System daemons.

release		Release building Makefile & associated tools.

rescue		Build system for statically linked /rescue utilities.

sbin		System commands.

secure		Cryptographic libraries and commands.

share		Shared resources.

sys		Kernel sources.

tools		Utilities for regression testing and miscellaneous tasks.

usr.bin		User commands.

usr.sbin	System administration commands.


For information on synchronizing your source tree with one or more of
the FreeBSD Project's development branches, please see:

  http://www.freebsd.org/doc/en_US.ISO8859-1/books/handbook/synching.html