1
0
mirror of https://git.FreeBSD.org/src.git synced 2024-11-21 07:15:49 +00:00
freebsd/sys
Adrian Chadd 842a2c1ad3 uath: flush data/commands to the firmware before changing channel / state
The driver wasn't stable - it would start fine, but during scan
it would eventually hang and no further command endpoint transfers
would complete.

After adding some debugging and looking at the logs I noticed that
things went sideways once a /data/ frame was sent.  The channel
change config happened between the data frame being sent and
being completed.

My guess is that the firmware doesn't like a channel change
and reset whilst there's pending data frames.  Checking the Linux
driver I found that it was doing a flush before a channel change,
and we're doing it afterwards.  This acts like a fence around
ensuring scheduled TX work has completed.  In net80211 the
transmit path and the control path aren't serialised, so it's
very often the case that ioctls, state changes, etc occur
whilst in parallel there are frame transmits being scheduled.

This seems to happen more frequently on a more recent, high core
(8) machine with XHCI.  I remember testing this driver years ago
on single and dual core CPU laptops with no problems.

So, add some flushes - before a channel change, and during
a transition to AUTH when the BSS config is being programmed into
the firmware.  These two fences seem enough to reliably
associate as a 2GHz and 5GHz STA.

Note that this isn't entirely blocking all newly queued
transmit work from occuring until after the NIC has finished
configuration.  That will need some further investigation.

Locally tested:

  * Wistron NuWeb AR5523 dual-band NIC, STA mode, 2/5GHz

Differential Revision:	https://reviews.freebsd.org/D47655
2024-11-18 20:50:41 -08:00
..
amd64
arm aw_wdog: disable timer on attach 2024-11-16 15:55:27 -04:00
arm64
bsm
cam
cddl
compat LinuxKPI: Use IfAPI to get LLADDR 2024-11-13 14:31:20 -05:00
conf conf: Fix KCSAN enablement checking 2024-11-17 16:40:33 +00:00
contrib
crypto
ddb
dev uath: flush data/commands to the firmware before changing channel / state 2024-11-18 20:50:41 -08:00
dts
fs
gdb
geom g_eli: update comment for bool return type 2024-11-13 15:13:35 -05:00
gnu
i386
isa
kern aio: remove write-only jobid & kernelinfo 2024-11-15 10:47:46 -05:00
kgssapi
libkern
modules riscv: Add support for building vmm as a kernel module 2024-11-13 14:15:07 +00:00
net rtsock: fix panic in rtsock_msg_buffer() 2024-11-18 14:12:42 -08:00
net80211 net80211: add IEEE80211_IS_QOS_NULL() 2024-11-18 20:50:17 -08:00
netgraph
netinet tcp: define tcp_lro_log() only when TCP_BLACKBOX is defined 2024-11-17 19:21:01 +01:00
netinet6 inpcb: Constify address parameters to in6 pcb lookup routines 2024-11-14 19:59:04 +00:00
netipsec net: Include private header in more needed places 2024-11-13 14:30:59 -05:00
netlink netlink: Don't directly access ifnet members 2024-11-13 14:30:58 -05:00
netpfil pf: clean up pflow sockets on jail removal 2024-11-18 11:06:46 +01:00
netsmb
nfs
nfsclient
nfsserver
nlm
ofed
opencrypto
powerpc
riscv aw_syscon: enable for Allwinner D1 (riscv) 2024-11-16 15:04:04 -04:00
rpc
security
sys aio: remove write-only jobid & kernelinfo 2024-11-15 10:47:46 -05:00
teken
tests
tools
ufs SU+J: all writes to SU journal must be exempt from runningbufspace throttling 2024-11-13 21:35:03 +02:00
vm vm: static-ize vm_page_alloc_after() 2024-11-17 12:19:00 -06:00
x86
xdr
xen
Makefile
README.md

FreeBSD Kernel Source:

This directory contains the source files and build glue that make up the FreeBSD kernel and its modules, including both original and contributed software.

Kernel configuration files are located in the conf/ subdirectory of each architecture. GENERIC is the configuration used in release builds. NOTES contains documentation of all possible entries. LINT is a compile-only configuration used to maximize build coverage and detect regressions.

Documentation:

Source code documentation is maintained in a set of man pages, under section 9. These pages are located in share/man/man9, from the top-level of the src tree. Consult intro(9) for an overview of existing pages.

Some additional high-level documentation of the kernel is maintained in the Architecture Handbook.

Source Roadmap:

Directory Description
amd64 AMD64 (64-bit x86) architecture support
arm 32-bit ARM architecture support
arm64 64-bit ARM (AArch64) architecture support
cam Common Access Method storage subsystem - cam(4) and ctl(4)
cddl CDDL-licensed optional sources such as DTrace
conf kernel build glue
compat Linux compatibility layer, FreeBSD 32-bit compatibility
contrib 3rd-party imported software such as OpenZFS
crypto crypto drivers
ddb interactive kernel debugger - ddb(4)
fs most filesystems, excluding UFS, NFS, and ZFS
dev device drivers and other arch independent code
gdb kernel remote GDB stub - gdb(4)
geom GEOM framework - geom(4)
i386 i386 (32-bit x86) architecture support
kern main part of the kernel
libkern libc-like and other support functions for kernel use
modules kernel module infrastructure
net core networking code
net80211 wireless networking (IEEE 802.11) - net80211(4)
netgraph graph-based networking subsystem - netgraph(4)
netinet IPv4 protocol implementation - inet(4)
netinet6 IPv6 protocol implementation - inet6(4)
netipsec IPsec protocol implementation - ipsec(4)
netpfil packet filters - ipfw(4), pf(4), and ipfilter(4)
opencrypto OpenCrypto framework - crypto(7)
powerpc PowerPC/POWER (32 and 64-bit) architecture support
riscv 64-bit RISC-V architecture support
security security facilities - audit(4) and mac(4)
sys kernel headers
tests kernel unit tests
ufs Unix File System - ffs(4)
vm virtual memory system
x86 code shared by AMD64 and i386 architectures