1
0
mirror of https://git.FreeBSD.org/src.git synced 2024-10-19 02:29:40 +00:00
freebsd/sys/net
Kristof Provost d6e5f8643d pf: rework pf_icmp_state_lookup() failure mode
If pf_icmp_state_lookup() finds a state but rejects it for not matching the
expected direction we should unlock the state (and NULL out *state). This
simplifies life for callers, and also ensures there's no confusion about what a
non-NULL returned state means.

Previously it could have been left in there by the caller, resulting in callers
unlocking the same state twice.

MFC after:	1 week
Sponsored by:	Rubicon Communications, LLC ("Netgate")

(cherry picked from commit 0578fe4922)
2024-09-04 10:53:07 +02:00
..
altq sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
route fibs: Limit the WARNING message to only once when setting up with multiple fibs 2024-08-02 02:04:54 +08:00
bpf_buffer.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
bpf_buffer.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
bpf_filter.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
bpf_jitter.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
bpf_jitter.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
bpf_zerocopy.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
bpf_zerocopy.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
bpf.c bpf: Make dead_bpf_if const 2023-11-13 11:58:34 +08:00
bpf.h bpf: Make bpf_peers_present a boolean inline function 2024-06-17 12:10:23 +08:00
bpfdesc.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
bridgestp.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
bridgestp.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
debugnet_inet.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
debugnet_int.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
debugnet.c debugnet: Fix logging of frame length 2024-04-15 12:03:06 +08:00
debugnet.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
dlt.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
ethernet.h Teach if_smsc to get MAC from bootargs. 2024-01-01 10:13:13 +01:00
firewire.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
ieee8023ad_lacp.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
ieee8023ad_lacp.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
ieee_oui.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_arp.h Support ARP for 802 networks 2024-04-27 10:47:16 -04:00
if_bridge.c sys/net/if_bridge: support non-INET kernels 2024-05-10 22:10:29 +08:00
if_bridgevar.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_clone.c sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_clone.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_dead.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
if_debug.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
if_disc.c sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_dl.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_edsc.c sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_enc.c if_enc(4): Prefer the boolean form when calling bpf_peers_present() 2024-06-17 12:10:11 +08:00
if_enc.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_epair.c sys: Use mbufq_empty instead of comparing mbufq_len against 0 2024-01-18 14:37:32 -08:00
if_ethersubr.c ethernet: Fix logging of frame length 2024-04-15 12:02:57 +08:00
if_fwsubr.c sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_gif.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
if_gif.h sys: Remove $FreeBSD$: one-line .c comment pattern 2023-08-23 11:43:22 -06:00
if_gre.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
if_gre.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_infiniband.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
if_ipsec.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
if_ipsec.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_lagg.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
if_lagg.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_llatbl.c if_llatbl: Fix a typo in a KASSERT message 2024-01-25 07:52:38 +01:00
if_llatbl.h sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
if_llc.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_loop.c sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_me.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
if_media.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
if_media.h sys: Remove $FreeBSD$: one-line .c comment pattern 2023-08-23 11:43:22 -06:00
if_mib.c sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_mib.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_pflog.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_pfsync.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_sppp.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_spppfr.c sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_spppsubr.c sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_stf.c sys: Remove $FreeBSD$: one-line .c comment pattern 2023-08-23 11:43:22 -06:00
if_tap.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_tun.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_tuntap.c if_tuntap: fix NOIP build 2024-01-12 22:09:27 +01:00
if_types.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_var.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
if_vlan_var.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if_vlan.c if_vlan: Always default to 802.1q. 2023-09-08 12:09:23 +02:00
if_vxlan.c if_vxlan(4): Move the allocating of statistics counters below if_alloc() 2024-07-16 23:53:18 +08:00
if_vxlan.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
if.c ifnet: Remove dead code 2024-07-08 19:36:30 +08:00
if.h net: Fix two typos in source code comments 2024-01-23 07:47:32 +01:00
ifdi_if.m iflib: invert default restart on VLAN changes 2023-09-11 15:34:21 -07:00
iflib_clone.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
iflib_private.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
iflib.c iflib: Add subinterface interrupt allocation function 2024-07-30 21:29:23 -07:00
iflib.h iflib: Add subinterface interrupt allocation function 2024-07-30 21:29:23 -07:00
ifq.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
infiniband.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
mp_ring.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
mp_ring.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
mppc.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
mppcc.c sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
mppcd.c sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
netisr_internal.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
netisr.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
netisr.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
netmap_legacy.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
netmap_user.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
netmap_virt.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
netmap.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
paravirt.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
pfil.c pfil: don't leak pfil_head_t on interface detach 2024-01-08 16:31:38 -08:00
pfil.h sys: Remove $FreeBSD$: one-line .c comment pattern 2023-08-23 11:43:22 -06:00
pfkeyv2.h sys: Remove $FreeBSD$: one-line .c comment pattern 2023-08-23 11:43:22 -06:00
pfvar.h pf: rework pf_icmp_state_lookup() failure mode 2024-09-04 10:53:07 +02:00
ppp_defs.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
radix.c sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
radix.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
raw_cb.c sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
raw_cb.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
raw_usrreq.c sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
rndis.h sys: Remove $FreeBSD$: one-line .c comment pattern 2023-08-23 11:43:22 -06:00
route.c sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
route.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
rss_config.c sys: Remove $FreeBSD$: two-line .c pattern 2023-08-23 11:43:23 -06:00
rss_config.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
rtsock.c rtsock: Fix a typo in a source code comment 2024-01-25 07:49:39 +01:00
sff8436.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
sff8472.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
slcompress.c sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
slcompress.h sys: Remove $FreeBSD$: one-line .h pattern 2023-08-23 11:43:22 -06:00
toeplitz.c sys: Remove $FreeBSD$: one-line .c pattern 2023-08-23 11:43:25 -06:00
toeplitz.h sys: Remove $FreeBSD$: two-line .h pattern 2023-08-23 11:43:20 -06:00
vnet.c vnet: (read) lock the vnet list while iterating it 2023-12-14 09:34:32 +01:00
vnet.h vnet: add CURVNET_ASSERT_SET for !VIMAGE 2024-03-15 10:58:54 -07:00