1
0
mirror of https://git.FreeBSD.org/src.git synced 2024-12-19 10:53:58 +00:00
freebsd/lib
John Polstra c97c8f4a3c Fix a bug in __ivaliduser_sa() which caused some rsh/rlogin attempts
to fail needlessly if a reverse DNS lookup of the IP address didn't
come up with a hostname.  As a comment in the code clearly stated,
the "damn hostname" was looked up only for the purpose of netgroup
matching.  But if that lookup failed, the function bailed out
immediately even though in many cases netgroup matching would not
be used.

This change marks the hostname as unknown but continues.  Where
netgroup matching is performed, an unknown hostname is handled
conservatively.  I.e., for "+@netgroup" (accept) entries an unknown
hostname never matches, and for "-@netgroup" (reject) entries an
unknown hostname always matches.

In the lines affected (only), I also fixed a few bogus casts.  There
are others, and in fact this entire file would be a good candidate
for a cleanup sweep.

Reviewed by:	imp (wearing his flourescent yellow Security Team cap)
MFC after:	2 days
2002-08-24 17:37:42 +00:00
..
compat Updated libc/libc_r that fixes the FreeBSD-SA-02:28.resolv resolver bug. 2002-08-04 05:51:05 +00:00
csu Drop support for COPY, -c has been the default mode of install(1) 2002-07-29 09:40:17 +00:00
libalias Don't forget to recalculate the IP checksum of the original 2002-07-23 00:16:19 +00:00
libatm
libbind
libbz2
libc Fix a bug in __ivaliduser_sa() which caused some rsh/rlogin attempts 2002-08-24 17:37:42 +00:00
libc_r
libcalendar
libcam
libcom_err
libcompat
libcrypt
libdevinfo o Merge <machine/ansi.h> and <machine/types.h> into a new header 2002-08-21 16:20:02 +00:00
libdevstat
libdisk
libedit
libfetch Surround prototypes with __BEGIN_DECLS / __END_DECLS. 2002-07-22 16:11:39 +00:00
libform
libftpio
libio
libipsec
libipx
libisc
libkse
libkvm &x is not a format string 2002-08-24 07:15:55 +00:00
libmd
libmenu
libmilter
libmp
libncp
libncurses o Merge <machine/ansi.h> and <machine/types.h> into a new header 2002-08-21 16:20:02 +00:00
libnetgraph
libopie
libpam Since pam_get_authtok(3) doesn't know about our options structure, setting 2002-07-30 08:32:03 +00:00
libpanel
libpcap
libpthread
libradius mdoc(7) police: tidy up the formatting. 2002-08-09 12:07:17 +00:00
librpcsvc
libsbuf
libsm
libsmb
libsmdb
libsmutil
libstand o Merge <machine/ansi.h> and <machine/types.h> into a new header 2002-08-21 16:20:02 +00:00
libtacplus
libtelnet
libufs Wrap the header to prevent multiple inclusion, and mark the DECLS section. 2002-08-22 23:35:35 +00:00
libugidfw Use "ugidfw.h" rather than <ugidfw.h> so that mkdep can find it. 2002-08-14 22:30:07 +00:00
libusbhid
libutil Add LOGIN_SETMAC, which will indicate to the user context management code 2002-08-16 02:14:21 +00:00
libvgl
libwrap
libxpg4
liby
libypclnt
libz Fix an easy warning in a local addition. 2002-08-01 11:29:05 +00:00
msun
ncurses o Merge <machine/ansi.h> and <machine/types.h> into a new header 2002-08-21 16:20:02 +00:00
Makefile Hook up libugidfw to the build. 2002-08-02 07:09:53 +00:00
Makefile.inc