mirror of
https://git.FreeBSD.org/src.git
synced 2024-12-24 11:29:10 +00:00
cfb5b3256b
This time, change the default CFLAGS to match the simple defaults that the tinderboxes use. That is, don't use -fno-strict-aliasing by default. My last attempt to re-anable -Werror gave me a lesson in what strict aliasing is all about. There was code in libthr that wasn't 64-bit clean. The default use of -fno-strict-aliasing hid that. By using -fno-strict-aliasing by default we were choosing to ignore problems in code which had the potential to shoot ourselves in the foot. Sometimes it would be the 64-bit foot. I have both feet. The left ones are 32 bits and the right ones are 64 bits. Don't ask about my endian orientation. :-) The -fno-strict-aliasing compiler arg can still be used if NO_STRING_ALIASING is define in make. We are early in the FreeBSD 8 development, so we have the opportunity to wait and see if this works for us. I am sure that people will complain. We can easily revert this. All I ask is that we take sides: clean code or not. YMMV. Note that by using -fno-strict-aliasing the build won't actually break. Only where WARNS is set (and -Werror is used) will a compiler warning break the build. The use of WARNS levels implies (to me at least) that the developer has taken some care to make the code pass basic checks. This commit makes those checks just a little bit more strict.
79 lines
2.0 KiB
Makefile
79 lines
2.0 KiB
Makefile
# $FreeBSD$
|
|
#
|
|
# This file contains common settings used for building FreeBSD
|
|
# sources.
|
|
|
|
# Enable various levels of compiler warning checks. These may be
|
|
# overridden (e.g. if using a non-gcc compiler) by defining NO_WARNS.
|
|
|
|
# for GCC: http://gcc.gnu.org/onlinedocs/gcc-3.0.4/gcc_3.html#IDX143
|
|
|
|
.if !defined(NO_WARNS) && ${CC} != "icc"
|
|
. if defined(CSTD)
|
|
. if ${CSTD} == "k&r"
|
|
CFLAGS += -traditional
|
|
. elif ${CSTD} == "c89" || ${CSTD} == "c90"
|
|
CFLAGS += -std=iso9899:1990
|
|
. elif ${CSTD} == "c94" || ${CSTD} == "c95"
|
|
CFLAGS += -std=iso9899:199409
|
|
. elif ${CSTD} == "c99"
|
|
CFLAGS += -std=iso9899:1999
|
|
. else
|
|
CFLAGS += -std=${CSTD}
|
|
. endif
|
|
# -pedantic is problematic because it also imposes namespace restrictions
|
|
#CFLAGS += -pedantic
|
|
. endif
|
|
. if defined(WARNS)
|
|
. if ${WARNS} >= 1
|
|
CWARNFLAGS += -Wsystem-headers
|
|
. if !defined(NO_WERROR)
|
|
CWARNFLAGS += -Werror
|
|
. endif
|
|
. endif
|
|
. if ${WARNS} >= 2
|
|
CWARNFLAGS += -Wall -Wno-format-y2k
|
|
. endif
|
|
. if ${WARNS} >= 3
|
|
CWARNFLAGS += -W -Wno-unused-parameter -Wstrict-prototypes\
|
|
-Wmissing-prototypes -Wpointer-arith
|
|
. endif
|
|
. if ${WARNS} >= 4
|
|
CWARNFLAGS += -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch\
|
|
-Wshadow -Wcast-align -Wunused-parameter
|
|
. endif
|
|
# BDECFLAGS
|
|
. if ${WARNS} >= 6
|
|
CWARNFLAGS += -Wchar-subscripts -Winline -Wnested-externs -Wredundant-decls
|
|
. endif
|
|
. if ${WARNS} >= 2 && ${WARNS} <= 4
|
|
# XXX Delete -Wuninitialized by default for now -- the compiler doesn't
|
|
# XXX always get it right.
|
|
CWARNFLAGS += -Wno-uninitialized
|
|
. endif
|
|
. if !defined(WITH_GCC3)
|
|
CWARNFLAGS += -Wno-pointer-sign
|
|
. endif
|
|
. endif
|
|
|
|
. if defined(FORMAT_AUDIT)
|
|
WFORMAT = 1
|
|
. endif
|
|
. if defined(WFORMAT)
|
|
. if ${WFORMAT} > 0
|
|
#CWARNFLAGS += -Wformat-nonliteral -Wformat-security -Wno-format-extra-args
|
|
CWARNFLAGS += -Wformat=2 -Wno-format-extra-args
|
|
. if !defined(NO_WERROR)
|
|
CWARNFLAGS += -Werror
|
|
. endif
|
|
. endif
|
|
. endif
|
|
.endif
|
|
|
|
.if defined(IGNORE_PRAGMA)
|
|
CWARNFLAGS += -Wno-unknown-pragmas
|
|
.endif
|
|
|
|
# Allow user-specified additional warning flags
|
|
CFLAGS += ${CWARNFLAGS}
|