Devin Teske 052f89691c Standardize the way functions build their arguments leading up to a dialog ... invocation. Specifically, "top-load" your arguments and in the order in- which they will be displayed. For example, many [if not all] widgets display information in the following order, top-to-bottom (visually): + backtitle (displayed behind the widget at top-left) + title (at the top of the `window') + prompt text (just below the title and above whatever widget you choose) + Depending on widget, _one_ of the following: - menu list - radio list - check list - text input box with initial text - [Xdialog(1)] 2x or 3x text input boxes - [dialog(1)] a multi-part form - progress bar - etc. (many more widget choices) + buttons (right below the selected widget) + [dialog(1)] the hline (displayed at bottom of `window') NOTE: Xdialog(1) accepts and silently ignores --hline When building local arguments for your dialog invocation, if the value can't be cleanly loaded into a local, add "# Calculated below" to the end of the local declaration while retaining the block order of argument declarations. Move other local declarations that are not associated with this top-loading the dialog arguments to right-above where they are first-used. Also, standardize on the names of the arguments. For example, always use $prompt (instead of sometimes $msg and sometimes $prompt); use $menu_list or $shell_list or $radio_list for those respective widgets; ad nauseum. While we're doing this, flush-out full arguments for many invocations that were passing NULL strings (making it unapparent if you were staring at this one invocation what argument that NULL string was supposed to represent). Last, while we're in startup/rcconf let's remove the unnecessary use of a GLOBAL (RCCONF_MENU_LIST) for the menu_list.		2013-06-02 20:02:50 +00:00
..
any.subr	Standardize the way functions build their arguments leading up to a dialog	2013-06-02 20:02:50 +00:00
cdrom.subr
common.subr	Add missing include.	2013-04-23 22:55:59 +00:00
directory.subr
dos.subr
floppy.subr
ftp.subr	Standardize the way functions build their arguments leading up to a dialog	2013-06-02 20:02:50 +00:00
httpproxy.subr
Makefile
network.subr
nfs.subr
options.subr	Standardize the way functions build their arguments leading up to a dialog	2013-06-02 20:02:50 +00:00
tcpip.subr	Similar to r251236, improve the portion of dialog(1) API in dialog.subr	2013-06-02 05:45:25 +00:00
ufs.subr
usb.subr