mirror of
https://git.FreeBSD.org/src.git
synced 2024-12-24 11:29:10 +00:00
2658b3bb8e
global mutex, accept_mtx, which serializes access to the following fields across all sockets: so_qlen so_incqlen so_qstate so_comp so_incomp so_list so_head While providing only coarse granularity, this approach avoids lock order issues between sockets by avoiding ownership of the fields by a specific socket and its per-socket mutexes. While here, rewrite soclose(), sofree(), soaccept(), and sonewconn() to add assertions, close additional races and address lock order concerns. In particular: - Reorganize the optimistic concurrency behavior in accept1() to always allocate a file descriptor with falloc() so that if we do find a socket, we don't have to encounter the "Oh, there wasn't a socket" race that can occur if falloc() sleeps in the current code, which broke inbound accept() ordering, not to mention requiring backing out socket state changes in a way that raced with the protocol level. We may want to add a lockless read of the queue state if polling of empty queues proves to be important to optimize. - In accept1(), soref() the socket while holding the accept lock so that the socket cannot be free'd in a race with the protocol layer. Likewise in netgraph equivilents of the accept1() code. - In sonewconn(), loop waiting for the queue to be small enough to insert our new socket once we've committed to inserting it, or races can occur that cause the incomplete socket queue to overfill. In the previously implementation, it was sufficient to simply tested once since calling soabort() didn't release synchronization permitting another thread to insert a socket as we discard a previous one. - In soclose()/sofree()/et al, it is the responsibility of the caller to remove a socket from the incomplete connection queue before calling soabort(), which prevents soabort() from having to walk into the accept socket to release the socket from its queue, and avoids races when releasing the accept mutex to enter soabort(), permitting soabort() to avoid lock ordering issues with the caller. - Generally cluster accept queue related operations together throughout these functions in order to facilitate locking. Annotate new locking in socketvar.h. |
||
---|---|---|
.. | ||
atm | ||
bluetooth | ||
netgraph.h | ||
ng_async.c | ||
ng_async.h | ||
ng_atmllc.c | ||
ng_atmllc.h | ||
ng_base.c | ||
ng_bpf.c | ||
ng_bpf.h | ||
ng_bridge.c | ||
ng_bridge.h | ||
ng_cisco.c | ||
ng_cisco.h | ||
ng_device.c | ||
ng_device.h | ||
ng_echo.c | ||
ng_echo.h | ||
ng_eiface.c | ||
ng_eiface.h | ||
ng_etf.c | ||
ng_etf.h | ||
ng_ether.c | ||
ng_ether.h | ||
ng_fec.c | ||
ng_fec.h | ||
ng_frame_relay.c | ||
ng_frame_relay.h | ||
ng_gif_demux.c | ||
ng_gif_demux.h | ||
ng_gif.c | ||
ng_gif.h | ||
ng_hole.c | ||
ng_hole.h | ||
ng_hub.c | ||
ng_hub.h | ||
ng_iface.c | ||
ng_iface.h | ||
ng_ip_input.c | ||
ng_ip_input.h | ||
ng_ksocket.c | ||
ng_ksocket.h | ||
ng_l2tp.c | ||
ng_l2tp.h | ||
ng_lmi.c | ||
ng_lmi.h | ||
ng_message.h | ||
ng_mppc.c | ||
ng_mppc.h | ||
ng_one2many.c | ||
ng_one2many.h | ||
ng_parse.c | ||
ng_parse.h | ||
ng_ppp.c | ||
ng_ppp.h | ||
ng_pppoe.c | ||
ng_pppoe.h | ||
ng_pptpgre.c | ||
ng_pptpgre.h | ||
ng_rfc1490.c | ||
ng_rfc1490.h | ||
ng_sample.c | ||
ng_sample.h | ||
ng_socket.c | ||
ng_socket.h | ||
ng_socketvar.h | ||
ng_source.c | ||
ng_source.h | ||
ng_split.c | ||
ng_split.h | ||
ng_sppp.c | ||
ng_sppp.h | ||
ng_tee.c | ||
ng_tee.h | ||
ng_tty.c | ||
ng_tty.h | ||
ng_UI.c | ||
ng_UI.h | ||
ng_vjc.c | ||
ng_vjc.h | ||
ng_vlan.c | ||
ng_vlan.h | ||
NOTES |